| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
There was a problem hiding this comment.
This pull request changes how the action decides whether to verify downloaded JDK signatures by making signature verification default to “on” for distributions that support it (currently Temurin and Microsoft), while keeping it “off” for other distributions unless explicitly enabled/disabled via input.
Changes:
Copilot reviewed 7 out of 9 changed files in this pull request and generated no comments.
Show a summary per file| File | Description |
|---|---|
| src/setup-java.ts | Adds getVerifySignatureInput() and passes verifySignature: boolean | undefined through to installers. |
| src/distributions/base-installer.ts | Defaults signature verification to supportsSignatureVerification() when input is unset. |
| README.md | Documents distribution-dependent defaults for verify-signature. |
| action.yml | Removes the hardcoded default so “unset” can be detected. |
| tests/setup-java.test.ts | Adds orchestration tests for explicit vs unset verify-signature. |
| tests/distributors/temurin-installer.test.ts | Updates Temurin tests to verify “default on” and “explicitly off”. |
| tests/distributors/microsoft-installer.test.ts | Updates Microsoft tests to verify “default on”. |
| dist/setup/index.js | Updates compiled output for setup logic changes. |
| dist/setup/242.index.js | Updates compiled output for base installer defaulting changes. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
This pull request updates the Java setup action to change how signature verification is handled for downloaded Java packages. Signature verification is now enabled by default for the temurin and microsoft distributions, while remaining disabled for others unless explicitly set. The changes also update documentation, input handling, and tests to reflect this new default behavior.
Key changes include:
Default Behavior and Input Handling:
Testing and Validation:
These changes ensure better security defaults for supported distributions while allowing users to override signature verification behavior as needed.