Corretto toolcache folder name fix - #26
Open
IvanZosimov wants to merge 8 commits into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
marko-zivic-93
approved these changes
Apr 7, 2023
marko-zivic-93
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
Nice!
Sorry, something went wrong.
added 2 commits
April 7, 2023 12:04
dmitry-shibanov
approved these changes
Apr 7, 2023
MaksimZhukov
approved these changes
Apr 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Similarly to Zulu, Corretto uses semver-like notation for tagging it's versions instead of real semver, e.g. 12.0.6.3.10. Because of this fact, action couldn't find preinstalled version of the Corretto JDK in the toolcache. In scope of this PR the internal interpretation of the Corretto version notation is changed like that (12.0.6.3.10 -> 12.0.6+3.10) to be able to use the node-semver package.
Related issue:
#474
Check list: