FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(resetsetter): 重置属性setter by apr01chell · Pull Request #77 · alibaba/lowcode-engine-ext · GitHub

feat(resetsetter): 重置属性setter - #77

Open
apr01chell wants to merge 2 commits into
alibaba:mainfrom
apr01chell:feat/resetsetter
Open

feat(resetsetter): 重置属性setter#77
apr01chell wants to merge 2 commits into
alibaba:mainfrom
apr01chell:feat/resetsetter

Conversation

Copy link
Copy Markdown
Contributor

重置当前属性的setter

alibaba/lowcode-engine#2795

Comment thread src/setter/reset-setter/index.tsx Outdated
render() {
const tipContext = intlNode('Reset Attribute');

// return <a onClick={ this.resetIconClickHandler }> {tipContext} </a>;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

这里的注释去掉。

Comment thread src/setter/reset-setter/index.less Outdated
@@ -0,0 +1 @@
/* write style here */

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

这个文件是不是可以删掉

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

可以删除的,我把他和variable-setter的一块删除了吧

Comment thread src/setter/mixed-setter/index.tsx Outdated

let setterContent: any;
let actions: any;
if (n < 3) {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

这块的逻辑,可以在PR里面补充一些截图吗?我想看看交互/逻辑上要不要优化。

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

ResetSetter不会单独存在,两个setter的时候resetset在最后面。大于两个了前面是切换setter后面是resetsetter

一开始想把resetsetter合到切换setter中,但是重置的时候使用不方便,但是放两个图标有的不开启resetsetter又不太好看

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

都超过2个了这种ui看着还凑合

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

这种场景下展示的效果呢?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

另外,这里没有重置按钮吗?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

我么有开启全局resetsetter,这个属性也没有配置resetsetter

可以开启全局,我看一下这里的效果。

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

之前那个截图就是开启了全局的

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

开启全局会影响这个地方吗?

我觉得不影响比较好。重置的时候,清空变量绑定,并将值还原。

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

嗯,那就按你说的这个逻辑我改一下。在有三个setter并且有variable和reset setter时,最后一个位置放resetsetter,倒数第二个放variableSetter。如果没有variableSetter第二个位置就是switchAction。

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

如果没有variableSetter,就直接放 reset setter 就好。

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL