feat: allow users to indicate files dir - #509
Merged
jorgepiloto merged 2 commits intoJun 19, 2024
Merged
jorgepiloto merged 2 commits into
jorgepiloto merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Sorry, something went wrong.
RobPasMue
reviewed
Jun 18, 2024
RobPasMue
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM!
Sorry, something went wrong.
RobPasMue
approved these changes
Jun 18, 2024
SMoraisAnsys
approved these changes
Jun 19, 2024
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM, this will be valuable for sure !
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Merging and patching later. |
Sorry, something went wrong.
jorgepiloto
added a commit
that referenced
this pull request
Jun 19, 2024
germa89
added a commit
to ansys/pymapdl
that referenced
this pull request
Jun 20, 2024
7 of 10 tasks
germa89
added a commit
to ansys/pymapdl
that referenced
this pull request
Jun 24, 2024
* ci: checking documentation style in Examples directory too. As per: ansys/actions#509 * Adding changelog entry: 3191.changed.md * feat: symbolic link vale configuration in examples directory to documentation vale configuration file. * Adding changelog entry: 3191.changed.md * fix: style path in vale file * Update examples/.vale.ini Co-authored-by: Camille <78221213+clatapie@users.noreply.github.com> --------- Co-authored-by: pyansys-ci-bot <pyansys.github.bot@ansys.com> Co-authored-by: Camille <78221213+clatapie@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a discussion on #432, we thought about allowing users to specify the location of their documentation files. With these changes, projects with doc/ and examples/ folders can now run: