FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

GH-110: Flight SQL JDBC related StringView components implementation by ViggoC · Pull Request #905 · apache/arrow-java · GitHub

GH-110: Flight SQL JDBC related StringView components implementation - #905

Merged
lidavidm merged 7 commits into
apache:mainfrom
ViggoC:gh-110
Dec 4, 2025
Merged

GH-110: Flight SQL JDBC related StringView components implementation#905
lidavidm merged 7 commits into
apache:mainfrom
ViggoC:gh-110

Conversation

ViggoC commented Nov 5, 2025

Copy link
Copy Markdown
Contributor

What's Changed

Flight SQL JDBC related StringView components implementation.

Closes #110.

This comment has been minimized.

ViggoC commented Nov 5, 2025

Copy link
Copy Markdown
Contributor Author

@lidavidm I have drafted something; could you help me determine if I am on the right track? Currently, all the tests are being modified in-place, and I plan to refine them further. Do you think there are additional tests I should include?

lidavidm added the enhancement PRs that add or improve features. label Nov 10, 2025

lidavidm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks reasonable to me.

Copy link
Copy Markdown
Member

Thanks for your implementation! Our project is being blocked by this. What help I can provide so this pr can be merged soon?

ViggoC marked this pull request as ready for review November 19, 2025 13:32
github-actions Bot added this to the 18.4.0 milestone Nov 19, 2025

ViggoC commented Nov 19, 2025

Copy link
Copy Markdown
Contributor Author

@lewiszlw It's ready for review now.

Copy link
Copy Markdown
Member

I build jdbc driver package from your branch and tested it in our project, but got error Unsupported vector type: org.apache.arrow.driver.jdbc.shaded.org.apache.arrow.vector.ViewVarBinaryVector. @ViggoC

ViggoC commented Nov 20, 2025

Copy link
Copy Markdown
Contributor Author

could you share the stack? @lewiszlw

Copy link
Copy Markdown
Member

could you share the stack? @lewiszlw

Our stack is rust built server based on Datafusion query engine, and expose flight sql api. Our clients are Java stack.

I used dbevaer software to verify your branch.

ViggoC commented Nov 21, 2025

Copy link
Copy Markdown
Contributor Author

@lewiszlw
From your error message, I can confirm it's because ArrowFlightJdbcAccessor doesn't support StringView. But I'm not familiar with Flight JDBC, so I'm not sure how much work still need to fully support StringView. I need to first build an end-to-end test to confirm which parts are not yet supported.

Copy link
Copy Markdown
Member

I sent a pr to your branch. I'm testing it. Note that I can only test binary view type. @ViggoC

ViggoC commented Nov 21, 2025

Copy link
Copy Markdown
Contributor Author

@lewiszlw Given that you have a real usage environment, it would be great if you are willing to make the fixes.

Copy link
Copy Markdown
Member

I've sent a pr to your branch ViggoC#1. @ViggoC

lewiszlw left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I tested this pr in our project.

lidavidm commented Dec 4, 2025

Copy link
Copy Markdown
Member

JNI failures are unrelated.

lidavidm merged commit 033ecc3 into apache:main Dec 4, 2025
22 of 25 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement PRs that add or improve features.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Java] Flight SQL JDBC related StringView components implementation

3 participants


Back | FazBrowse Home | New Git URL