FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

MINOR: Add private constructor to UuidType singleton by tmater · Pull Request #945 · apache/arrow-java · GitHub

/ arrow-java Public

MINOR: Add private constructor to UuidType singleton - #945

Merged
jbonofre merged 3 commits into
apache:mainfrom
tmater:uuidtype_singleton
Jan 9, 2026
ConversationCommits (3)ChecksFiles changed
Merged

MINOR: Add private constructor to UuidType singleton#945
jbonofre merged 3 commits into
apache:mainfrom
tmater:uuidtype_singleton

Conversation

tmater commented Jan 5, 2026

Copy link
Copy Markdown
Contributor

Add private constructor to UuidType singleton.

This comment has been minimized.

Sign in to view
lidavidm added bug-fix PRs that fix a big. labels Jan 6, 2026
github-actions Bot added this to the 18.4.0 milestone Jan 6, 2026
lidavidm reviewed Jan 6, 2026
View reviewed changes

lidavidm left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

All builds fail:

Error:  Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.14.0:compile (default-compile) on project arrow-vector: Compilation failure: Compilation failure: 
Error:  /build/vector/src/main/java/org/apache/arrow/vector/UuidVector.java:[72,52] error: UuidType() has private access in UuidType
Error:  /build/vector/src/main/java/org/apache/arrow/vector/UuidVector.java:[102,52] error: UuidType() has private access in UuidType

tmater commented Jan 7, 2026

Copy link
Copy Markdown
Contributor Author

All builds fail:

Error:  Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.14.0:compile (default-compile) on project arrow-vector: Compilation failure: Compilation failure: 
Error:  /build/vector/src/main/java/org/apache/arrow/vector/UuidVector.java:[72,52] error: UuidType() has private access in UuidType
Error:  /build/vector/src/main/java/org/apache/arrow/vector/UuidVector.java:[102,52] error: UuidType() has private access in UuidType

Thank you for looking into it @lidavidm.
I thought I ran a local build 😅.
Fully updated the UuidType usage.

jhrotko approved these changes Jan 8, 2026
View reviewed changes

jhrotko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM!

lidavidm approved these changes Jan 9, 2026
View reviewed changes

lidavidm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'll let JB handle merging

jbonofre approved these changes Jan 9, 2026
View reviewed changes

jbonofre left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM.

Do you mind to rebase in order to have CI happy ?

tmater force-pushed the uuidtype_singleton branch from 530d5a8 to cd32ddb Compare January 9, 2026 08:27

tmater commented Jan 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

LGTM.

Do you mind to rebase in order to have CI happy ?

Thank you for the review!
Not at all, rebased.

jbonofre commented Jan 9, 2026

Copy link
Copy Markdown
Member

@tmater thanks ! I just ran the CI, I will merge as soon as it's all green.

jbonofre commented Jan 9, 2026

Copy link
Copy Markdown
Member

@tmater I see failure in RoundStripTest:

Error:  Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.14.0:testCompile (default-testCompile) on project arrow-c-data: Compilation failure: Compilation failure: 
Error:  /build/c/src/test/java/org/apache/arrow/c/RoundtripTest.java:[813,43] error: cannot find symbol
Error:    symbol:   variable INSTANCE
Error:    location: class UuidType

tmater commented Jan 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@tmater I see failure in RoundStripTest:

Error:  Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.14.0:testCompile (default-testCompile) on project arrow-c-data: Compilation failure: Compilation failure: 
Error:  /build/c/src/test/java/org/apache/arrow/c/RoundtripTest.java:[813,43] error: cannot find symbol
Error:    symbol:   variable INSTANCE
Error:    location: class UuidType

Interesting, there was a UuidType/UuidVector implementation in RoundStripTest. Removed it.

jbonofre merged commit bd3a6ee into apache:main Jan 9, 2026
26 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jbonofre jbonofre approved these changes
lidavidm lidavidm approved these changes
laurentgo Awaiting requested review from laurentgo laurentgo is a code owner
wgtmac Awaiting requested review from wgtmac wgtmac is a code owner
+1 more reviewer
jhrotko jhrotko approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug-fix PRs that fix a big.

Projects

None yet

Milestone

19.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL