Exclude JDK 8 - temurin, adopt-openj9 on macos, use defaults values - #238
Merged
slawekjaranowski merged 1 commit intoMay 3, 2024
Merged
Exclude JDK 8 - temurin, adopt-openj9 on macos, use defaults values#238slawekjaranowski merged 1 commit into
slawekjaranowski merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
elharo
approved these changes
May 2, 2024
olamy
reviewed
May 2, 2024
Comment thread
.github/workflows/maven-verify.yml
elharo
reviewed
May 2, 2024
Comment thread
.github/workflows/maven-verify.yml
| matrix-exclude: '[{ "jdk": "8", "distribution": "microsoft"},{ "jdk": "20", "distribution": "microsoft"},{ "jdk": "20", "distribution": "adopt-openj9"},]' | ||
| maven-matrix: '[ "3.6.3", "3.8.8", "3.9.5" ]' # Maven versions matrix for verify builds | ||
| matrix-exclude: '[ | ||
| { "jdk": "8", "distribution": "microsoft" }, |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Why is this one excluded? It's not a Mac
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
It has been excluded early ... probably microsoft distribution does not support jdk 8 at all
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.