[maven-plugin-tools-3.x] Stop depending on Wagon for nonProxyHosts matching - #1152
Merged
slachiewicz merged 1 commit intoAug 8, 2026
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
maven-plugin-tools-api carried a compile dependency on wagon-provider-api for two classes, as its own comment said: "wagon for proxy related classes". The whole of that use was building a ProxyInfo as a carrier for one string and handing it to ProxyUtils.validateNonProxyHosts. The matching itself is a handful of lines with nothing Maven-specific in it -- split on '|', treat '*' as a wildcard and '.' as a literal -- so it is done here instead, and the dependency goes. Tests cover the wildcard, the escaped dot, the pipe separator and the null cases. Nothing else in plugin-tools touches Wagon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #1151 to maven-plugin-tools-3.x. The cherry-pick was clean — JavadocSite.java is identical on the two branches.
maven-plugin-tools-api carries a compile dependency on wagon-provider-api for two classes, as its own comment says (<!-- wagon for proxy related classes -->). The whole use is building a ProxyInfo as a carrier for one string and passing it to ProxyUtils.validateNonProxyHosts. That matching is a handful of lines with nothing Maven-specific in it, so it is done in place and the dependency goes.
Verified on this branch: mvn -pl maven-plugin-tools-api test gives 48 tests, 0 failures — the 44 that were there plus the 4 new ones covering the wildcard, the escaped dot, the pipe separator and the null cases.
Why on a maintenance branch at all
3.x is the line that ships, and it is still active — this branch had a commit yesterday. Removing a compile dependency does change the published POM of a future 3.x release, so this is a judgement call rather than an obvious bugfix, and I am happy for it to be declined if you would rather 3.x took fixes only. The equivalent change for master is #1151.