remove the unsupported itemsPerPage property passed to fetch
cache Hydra resource parameter discovery per Resource instance
deduplicate concurrent parameter requests
cache successful empty results
evict rejected requests from the cache to allow retries
document the cache lifetime
Context
Hydra resource parameters are discovered by requesting the collection endpoint
and reading its hydra:search mapping.
The parser previously passed itemsPerPage as a RequestInit property. This
property is not supported by fetch and was silently ignored. In addition,
concurrent calls to getParameters() or repeated calls returning no parameters
could trigger multiple identical collection requests.
The result is now stored in a WeakMap keyed by the Resource instance. This
keeps caches isolated between documentation parses and allows entries to be
garbage-collected with their resource.
Rejected requests are removed from the cache so that a later call can retry.
This change does not remove the initial Hydra discovery request or assume an
API Platform-specific pagination parameter. It prevents repeated discovery
requests in a generic way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
Hydra resource parameters are discovered by requesting the collection endpoint
and reading its hydra:search mapping.
The parser previously passed itemsPerPage as a RequestInit property. This
property is not supported by fetch and was silently ignored. In addition,
concurrent calls to getParameters() or repeated calls returning no parameters
could trigger multiple identical collection requests.
The result is now stored in a WeakMap keyed by the Resource instance. This
keeps caches isolated between documentation parses and allows entries to be
garbage-collected with their resource.
Rejected requests are removed from the cache so that a later call can retry.
This change does not remove the initial Hydra discovery request or assume an
API Platform-specific pagination parameter. It prevents repeated discovery
requests in a generic way.
Related to #115.
Related to api-platform/admin#508.
Tests
Added dedicated coverage for:
The parser test retains integration coverage for wiring getParameters() and
the resulting fetch request.
Validation: