FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[`airflow`] Add missing `AIR302` attribute check by Lee-W · Pull Request #17115 · astral-sh/ruff · GitHub

  1. astral-sh
  2. ruff

Repository navigation

[airflow] Add missing AIR302 attribute check - #17115

Merged
ntBre merged 3 commits into
astral-sh:mainfrom
astronomer:add-more-AIR303-condition
Apr 9, 2025
ConversationCommits (3)ChecksFiles changed
Merged

[airflow] Add missing AIR302 attribute check#17115
ntBre merged 3 commits into
astral-sh:mainfrom
astronomer:add-more-AIR303-condition

Conversation

Lee-W commented Apr 1, 2025

Copy link
Copy Markdown
Contributor

Summary

attribute check was missing in the previous implementation

e.g.

from airflow.api.auth.backend import basic_auth

basic_auth.auth_current_user

This PR adds this kind of check.

Test Plan

The test case has been added to the button of the existing test fixtures, confirmed to be correct and later reorgnaized

github-actions Bot commented Apr 1, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Lee-W force-pushed the add-more-AIR303-condition branch from c2f11da to 7aad00e Compare April 1, 2025 13:14
This was referenced Apr 1, 2025
Closed
Closed
sunank200 reviewed Apr 2, 2025
View reviewed changes

sunank200 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Lee-W force-pushed the add-more-AIR303-condition branch from 7aad00e to 189cf32 Compare April 2, 2025 10:01
dhruvmanila added rule Implementing or modifying a lint rule preview Related to preview-mode features labels Apr 2, 2025
Lee-W force-pushed the add-more-AIR303-condition branch 2 times, most recently from 5573369 to ebd06bb Compare April 3, 2025 02:22
Lee-W marked this pull request as draft April 3, 2025 02:22
Lee-W changed the title [airflow] Add misssing AIR303 attribute check [airflow] Add misssing AIR302 attribute check Apr 3, 2025
Lee-W force-pushed the add-more-AIR303-condition branch from ebd06bb to debb3a2 Compare April 8, 2025 03:31

Lee-W commented Apr 8, 2025

Copy link
Copy Markdown
Contributor Author

This PR is now based on #17278

Lee-W force-pushed the add-more-AIR303-condition branch 2 times, most recently from 76739c6 to 271f941 Compare April 8, 2025 13:11
Lee-W marked this pull request as ready for review April 8, 2025 13:11

Lee-W commented Apr 8, 2025

Copy link
Copy Markdown
Contributor Author

Thanks @ntBre, for merging #17278! This one is ready as well

Lee-W commented Apr 8, 2025

Copy link
Copy Markdown
Contributor Author

I guess we might need @dhruvmanila to confirm as well?

Lee-W changed the title [airflow] Add misssing AIR302 attribute check [airflow] Add missing AIR302 attribute check Apr 8, 2025

ntBre commented Apr 9, 2025

Copy link
Copy Markdown
Contributor

I can override Dhruv's review if needed 😉 Can you fix the merge conflicts? Then I'll try to review today.

Lee-W force-pushed the add-more-AIR303-condition branch from a925a8c to d1a7740 Compare April 9, 2025 15:09

Lee-W commented Apr 9, 2025

Copy link
Copy Markdown
Contributor Author

Just updated! 🙏

ntBre self-assigned this Apr 9, 2025
ntBre approved these changes Apr 9, 2025
View reviewed changes

ntBre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This looks good to me!

ntBre changed the title [airflow] Add missing AIR302 attribute check [airflow] Add missing AIR302 attribute check Apr 9, 2025
ntBre merged commit c87e3cc into astral-sh:main Apr 9, 2025
BrewTestBot mentioned this pull request Apr 10, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dhruvmanila dhruvmanila requested changes
ntBre ntBre approved these changes
+1 more reviewer
sunank200 sunank200 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

ntBre

Labels

preview Related to preview-mode features rule Implementing or modifying a lint rule

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL