Repository navigation
[ty] Include error context for overload consistency diagnostics - #24950
Merged
charliermarsh merged 1 commit intoMay 7, 2026
Merged
charliermarsh merged 1 commit into
charliermarsh merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 89.36%. The percentage of expected errors that received a diagnostic held steady at 85.49%. The number of fully passing files held steady at 88/134. |
Sorry, something went wrong.
Copy link
Copy Markdown
Memory usage reportMemory usage unchanged ✅ |
Sorry, something went wrong.
Copy link
Copy Markdown
ecosystem-analyzer resultsFailing projects:
No diagnostic changes detected ✅ Raw diff: pywin32 (https://github.com/mhammond/pywin32)
- FAILED old=abnormal exit(2) new=abnormal exit(2) |
Sorry, something went wrong.
charliermarsh
marked this pull request as ready for review
April 30, 2026 17:53
charliermarsh
requested review from
AlexWaygood,
carljm,
dcreager,
ibraheemdev and
sharkdp
as code owners
April 30, 2026 17:53
charliermarsh
force-pushed
the
charlie/overload-consistency-i
branch
from
0c11fd5 to
7a712ad
Compare
May 1, 2026 00:14
charliermarsh
force-pushed
the
charlie/overload-consistency-diagnostic
branch
from
d85036a to
e5c91a2
Compare
May 1, 2026 00:15
charliermarsh
force-pushed
the
charlie/overload-consistency-i
branch
from
7a712ad to
7963957
Compare
May 1, 2026 13:22
charliermarsh
force-pushed
the
charlie/overload-consistency-diagnostic
branch
from
e5c91a2 to
1f80e94
Compare
May 1, 2026 13:23
charliermarsh
force-pushed
the
charlie/overload-consistency-i
branch
from
7963957 to
02b7a7d
Compare
May 4, 2026 17:36
charliermarsh
force-pushed
the
charlie/overload-consistency-diagnostic
branch
from
1f80e94 to
3664af3
Compare
May 4, 2026 17:37
Copy link
Copy Markdown
Merging this PR will not alter performance✅ 57 untouched benchmarks Comparing charlie/overload-consistency-diagnostic (b5c4429) with main (0232ed8) Footnotes
|
Sorry, something went wrong.
charliermarsh
force-pushed
the
charlie/overload-consistency-i
branch
2 times, most recently
from
e32fb1f to
9288152
Compare
May 7, 2026 18:34
charliermarsh
force-pushed
the
charlie/overload-consistency-diagnostic
branch
from
3664af3 to
b5c4429
Compare
May 7, 2026 18:53
carljm
added a commit
that referenced
this pull request
May 8, 2026
* main: (23 commits) Lazily initialize `UnionBuilder` when transforming a `Union` (#25050) [ty] Speed-up find-references by using multithreading for cross-file searches (#25042) Revert "[ty] Lazily initialize `UnionBuilder` when transforming a union type" (#25049) [ty] Make text-based find-references pre-filter identifier boundary aware (#25036) [ty] Fix cross-file find-references for keyword arguments (#25043) [ty] Include TypedDict type context when inferring mixed constructors (#25039) [ty] Include TypedDict type context when inferring string keys (#25037) [ty] Lazily initialize `UnionBuilder` when transforming a union type (#24929) [ty] Skip global search for references if identifier is not externally visible (#25033) [ty] Support narrowing on `__class__` checks (#24997) [ty] Bump ecosystem-analyzer (#25032) [ty] Include error context for overload consistency diagnostics (#24950) [ty] Check non-generic overload implementations (#24936) Filter overloads based on return type for ParamSpec mapping (#24769) [ty] Add versioned parameters for dataclass decorator (#25029) [ty] Project reachability constraints before narrowing (#24982) [ty] Emit folding ranges from the language server for multi-line block headers. (#24978) [ty] Allow ParamSpec specialization through unioned generic classes (#24826) [ty] Adjust start of block folding range to preserve visible header for character-precise LSP clients. (#24917) [ty] Use `as_i64` when comparing `IntLiteralType` instances (#25023) ...
thejchap
pushed a commit
to thejchap/ruff
that referenced
this pull request
May 23, 2026
…al-sh#24950) ## Summary No functional changes, but we now surface the error context from failed assignability when constructing diagnostics for invalid overload implementations (e.g., we now explain which parameter was mismatched).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
No functional changes, but we now surface the error context from failed assignability when constructing diagnostics for invalid overload implementations (e.g., we now explain which parameter was mismatched).