Repository navigation
[ty] Skip parameter accumulation for object variadics - #24976
Merged
charliermarsh merged 2 commits intoMay 3, 2026
Merged
charliermarsh merged 2 commits into
charliermarsh merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 89.34%. The percentage of expected errors that received a diagnostic held steady at 85.30%. The number of fully passing files held steady at 87/134. |
Sorry, something went wrong.
Copy link
Copy Markdown
Memory usage reportSummary
Significant changesClick to expand detailed breakdownflake8
sphinx
trio
prefect
|
Sorry, something went wrong.
charliermarsh
commented
May 3, 2026
Comment thread
crates/ruff_benchmark/benches/ty.rs
| setup_rayon(); | ||
|
|
||
| let mut code = "\ | ||
| def accepts_objects(first: int, *args: object) -> None: ... |
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Using *args: object makes the benchmark like 4x faster now, per #24974 (comment).
Sorry, something went wrong.
Copy link
Copy Markdown
ecosystem-analyzer resultsNo diagnostic changes detected ✅ |
Sorry, something went wrong.
Copy link
Copy Markdown
Merging this PR will improve performance by ×4.1⚡ 2 improved benchmarks Performance Changes
Comparing charlie/variadic-object-sink (b965477) with main (5ee1d0c) Footnotes
|
Sorry, something went wrong.
charliermarsh
marked this pull request as ready for review
May 3, 2026 00:41
charliermarsh
requested review from
AlexWaygood,
carljm,
dcreager,
ibraheemdev and
sharkdp
as code owners
May 3, 2026 00:41
carljm
added a commit
that referenced
this pull request
May 6, 2026
* main: (63 commits) Update uraimo/run-on-arch-action action to v3.1.0 (#25011) Update dependency astral-sh/uv to v0.11.10 (#25002) Update prek dependencies (#25003) Update taiki-e/install-action action to v2.75.25 (#25007) Update Rust crate mimalloc to v0.1.50 (#25006) Update Rust crate libc to v0.2.186 (#25005) Update maturin to v1.13.1 (#25009) Update CodSpeedHQ/action action to v4.15.0 (#25008) Update Rust crate jiff to v0.2.24 (#25004) Increase max value of `line-length` setting (#24962) [ty] Fix the Pyodide assets deployment in the ty playground. (#24994) [ty] Selectively promote a union of homogeneous fixed-length tuples to a single variadic tuple. (#24705) [ty] Cache results in desperate module resolution (#24977) [ty] implement proper handling of recursive types in `CycleDetector` (#24773) [ty] Skip parameter accumulation for object variadics (#24976) Add missing rust related files when detecting changes in CI (#24971) [ty] Expand support for narrowing within walruses (#24968) [ty] Fix missing visitor guard in `Callable` branch (#24964) [ty] Allow reference finding in stringified annotations (#24956) [ty] Unpack Union of TypedDict in various sites (#24958) ...
thejchap
pushed a commit
to thejchap/ruff
that referenced
this pull request
May 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.