Repository navigation
[ty] Speed-up find-references by using multithreading for cross-file searches - #25042
Merged
MichaReiser merged 1 commit intoMay 8, 2026
Merged
MichaReiser merged 1 commit into
MichaReiser merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
MichaReiser
requested review from
AlexWaygood,
BurntSushi,
Gankra,
carljm,
dcreager and
sharkdp
as code owners
May 8, 2026 11:10
MichaReiser
commented
May 8, 2026
Comment thread
crates/ty_ide/src/references.rs
Outdated
| } | ||
|
|
||
| // If the target text is found, do the more expensive semantic analysis | ||
| let references = if is_external_visible { |
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
We now branch here on whether to run the more expensive "search in the entire file" or "only rename keyword arguments and parameters". This allows us to share the heavy lifting between both cases
Sorry, something went wrong.
MichaReiser
force-pushed
the
micha/find-references-parallelize
branch
from
a0cc978 to
2364a8b
Compare
May 8, 2026 15:27
charliermarsh
approved these changes
May 8, 2026
MichaReiser
force-pushed
the
micha/find-references-parallelize
branch
from
2364a8b to
31ba26a
Compare
May 8, 2026 15:37
carljm
added a commit
that referenced
this pull request
May 8, 2026
* main: (23 commits) Lazily initialize `UnionBuilder` when transforming a `Union` (#25050) [ty] Speed-up find-references by using multithreading for cross-file searches (#25042) Revert "[ty] Lazily initialize `UnionBuilder` when transforming a union type" (#25049) [ty] Make text-based find-references pre-filter identifier boundary aware (#25036) [ty] Fix cross-file find-references for keyword arguments (#25043) [ty] Include TypedDict type context when inferring mixed constructors (#25039) [ty] Include TypedDict type context when inferring string keys (#25037) [ty] Lazily initialize `UnionBuilder` when transforming a union type (#24929) [ty] Skip global search for references if identifier is not externally visible (#25033) [ty] Support narrowing on `__class__` checks (#24997) [ty] Bump ecosystem-analyzer (#25032) [ty] Include error context for overload consistency diagnostics (#24950) [ty] Check non-generic overload implementations (#24936) Filter overloads based on return type for ParamSpec mapping (#24769) [ty] Add versioned parameters for dataclass decorator (#25029) [ty] Project reachability constraints before narrowing (#24982) [ty] Emit folding ranges from the language server for multi-line block headers. (#24978) [ty] Allow ParamSpec specialization through unioned generic classes (#24826) [ty] Adjust start of block folding range to preserve visible header for character-precise LSP clients. (#24917) [ty] Use `as_i64` when comparing `IntLiteralType` instances (#25023) ...
thejchap
pushed a commit
to thejchap/ruff
that referenced
this pull request
May 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cross-file find-references can be costly, because we need to read every file in the project.
To speed this up, run this on our thread pool.
Closes astral-sh/ty#1720