Added get_query_payload to astrometry_net - #3555
Conversation
Sorry, something went wrong.
|
please leave the deprecations alone, it's never a good idea to mix new features and cleanups in the same PR. And, yes, unfortunately the remote tests are really a pain for any of the modules that require authentication. |
Sorry, something went wrong.
|
I removed the deprecation removals entirely. If you want me to I have the deprecation removals on a separate branch and can submit a PR for that. Otherwise, this PR should be ready for review. |
Sorry, something went wrong.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #3555 +/- ##
==========================================
+ Coverage 72.76% 72.84% +0.07%
==========================================
Files 219 219
Lines 20543 20547 +4
==========================================
+ Hits 14948 14967 +19
+ Misses 5595 5580 -15 ☔ View full report in Codecov by Harness.
|
Sorry, something went wrong.
…yload for astrometry_net
Hey yall, I've added the get_query_payload kwarg to astrometry_net per #2040.
I originally set out to only add get_query_payload functionality, but I noticed too that astrometry_net had deprecated functionality related to solve_from_image. Since deprecation warnings were added back in astroquery 0.4.8 I decided to go through with removing what was deprecated. Going back and looking at closed PRs I think I took care of what yall intended with the deprecation.
All tests both local and remote passed fine for me, but looking back at some of the logs of CI runs it appears that all the remote tests are being skipped 🫤 .
When I ran the remote tests (locally with my api key) they all worked out for me, but just thought I'd throw that note in here just in case to be thorough.