| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
Codecov Report❌ Patch coverage is 97.47899% with 18 lines in your changes missing coverage. Please review.
@@ Coverage Diff @@
## main #3582 +/- ##
==========================================
+ Coverage 73.42% 73.96% +0.53%
==========================================
Files 230 231 +1
Lines 21362 21849 +487
==========================================
+ Hits 15686 16161 +475
- Misses 5676 5688 +12 ☔ View full report in Codecov by Harness.
|
Sorry, something went wrong.
|
@sedonaprice @taberger @cpparts For your visibility! Any feedback is appreciated. |
Sorry, something went wrong.
|
This is such a massive big PR that it will likely be only cleared after the next release is made (as there are other big PRs coming in well before this one that are all need to get though the finish line now) |
Sorry, something went wrong.
|
@bsipocz Thanks, and well understood. When do you estimate a review to support an automated release could be made with these changes included? This has important functionality for Roman catalog support included in it, for some context. There's no particular urgency in including this for the next milestone release, but interested in when could it be available as a --pre install version? |
Sorry, something went wrong.
|
Yes, once this is merged there can be a dev release with it on pypi. |
Sorry, something went wrong.
Updating docstrings, clarity
TAP URL constant, add comments Updating docstrings, don't set `available_collections` in method
Minor refactoring, more comments style Update default catalogs mapping name copilot comments Fixing collection names Update docstrings to be more explicit about region types fix style Add TODO about sky region classes
addressing comments from Sam uncommenting out line adjusting to new naming convention addressing more comments Starting off non-remote testing More test examples Style fixes to test_mast_remote Notes for non-remote tests
Adjusting from rebase Clear cache in non-remote tests
Catch up rebase
do not call network for default initializations of Catalogs
Avoid overflow errors updating tap_collections.json slight adjustments to parsing logic catalog tests typo correction addressing comments Some rebase fixes Rebase fix
Co-authored-by: Copilot <copilot@github.com> More doc fixes Co-authored-by: Copilot <copilot@github.com> Typos Co-authored-by: Copilot <copilot@github.com>
| Back | FazBrowse Home | New Git URL |
This pull request introduces a major refactor and modernization of the Catalogs interface in the MAST module, focusing on switching from the portal and catalogs.mast to VO-TAP. This interface has unified query workflows and enhanced discovery and filtering capabilities. It's a big one!
For a quick rundown of the intended workflow, I recommend starting with the new documentation (mast_catalog.rst).
MAST Catalogs Interface Refactor and Enhancements:
Testing and Documentation Updates: