FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Factor out the HITRAN reader so it can be used on pre-downloaded files by keflavich · Pull Request #3589 · astropy/astroquery · GitHub

/ astroquery Public

Factor out the HITRAN reader so it can be used on pre-downloaded files - #3589

Open
keflavich wants to merge 3 commits into
astropy:mainfrom
keflavich:hitran-reader
ConversationCommits (3)ChecksFiles changed
Open

Factor out the HITRAN reader so it can be used on pre-downloaded files#3589
keflavich wants to merge 3 commits into
astropy:mainfrom
keflavich:hitran-reader

Conversation

keflavich commented May 11, 2026

Copy link
Copy Markdown
Contributor

As in the title: the reader built into the hitran module can read downloadable .par files. This PR exposes it as a public function.

codecov Bot commented May 11, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.22%. Comparing base (f2fab73) to head (c80ad19).
⚠️ Report is 98 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3589      +/-   ##
==========================================
+ Coverage   73.17%   73.22%   +0.05%     
==========================================
  Files         227      227              
  Lines       21078    21100      +22     
==========================================
+ Hits        15423    15451      +28     
+ Misses       5655     5649       -6

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

bsipocz added the hitran label May 12, 2026
bsipocz added this to the 0.4.12 milestone May 12, 2026
bsipocz approved these changes May 12, 2026
View reviewed changes

bsipocz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This needs a changelog, but otherwise is looking good. I see a failing remote test and a failing doctest for hitran, but both are unrelated so fixing them doesn't have to be part of this PR.

keflavich commented May 12, 2026

Copy link
Copy Markdown
Contributor Author

i'll check on the remote test; hitran might have moved to login-only downloads

bsipocz commented May 12, 2026

Copy link
Copy Markdown
Member

i'll check on the remote test; hitran might have moved to login-only downloads

They just look to be a mismatched output with now having a few more returned lines

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

bsipocz bsipocz approved these changes

Assignees

No one assigned

Labels

hitran

Projects

None yet

Milestone

0.4.12

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL