Remove caller option check - #1007
Merged
JLHwung merged 4 commits intoNov 17, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Babel 7.12+ supports .caller options
JLHwung
force-pushed
the
remove-caller-option-check
branch
from
f257306 to
4be2eae
Compare
November 9, 2023 19:11
liuxingbaoyu
approved these changes
Nov 12, 2023
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Babel 7.12+ supports the .caller option. We can remove the feature detection now, which happens to fix compatibility between babel-loader and @babel/core@8.0.0-alpha.3, since we disallowed calling loadPartialConfig synchronously.
Please Read the CONTRIBUTING Guidelines
In particular the portion on Commit Message Formatting
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Behaviour is not changed.
Does this PR introduce a breaking change?
Closes #1006