Cherry-pick Swift toolchain changes from upstream - #2643
Merged
brentleyjones merged 1 commit intoFeb 4, 2025
Merged
brentleyjones merged 1 commit into
brentleyjones merged 1 commit into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
brentleyjones
requested review from
BalestraPatrick,
aaronsky,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
February 4, 2025 14:48
brentleyjones
referenced
this pull request
Feb 4, 2025
This is change 1 of _N_ to migrate the Swift build rules to use new-style Bazel toolchains. This change: * Updates the toolchain configuration rules to wrap the `SwiftToolchainInfo` provider in `platform_common.ToolchainInfo`, for future use by `toolchain()` rules. * Funnels all toolchain access through a new `swift_toolchain.get_toolchain()` function that looks up the toolchain using `ctx.toolchains`, falling back to the implicit attribute. Since `ctx.toolchains` isn't defined yet, the second change is a no-op but it simplifies future parts of the migration. PiperOrigin-RevId: 439638938
brentleyjones
force-pushed
the
bj/swift_toolchain
branch
from
a36766a to
49065f7
Compare
February 4, 2025 14:56
brentleyjones
marked this pull request as draft
February 4, 2025 15:08
brentleyjones
force-pushed
the
bj/swift_toolchain
branch
3 times, most recently
from
978278b to
201445b
Compare
February 4, 2025 15:44
brentleyjones
marked this pull request as ready for review
February 4, 2025 15:59
brentleyjones
enabled auto-merge (squash)
February 4, 2025 15:59
Copy link
Copy Markdown
Collaborator
Author
|
This is needed for rules_apple to support the upcoming rules_swift 3.0. |
Sorry, something went wrong.
brentleyjones
disabled auto-merge
February 4, 2025 18:28
brentleyjones
force-pushed
the
bj/swift_toolchain
branch
from
201445b to
9e0d149
Compare
February 4, 2025 18:36
luispadron
approved these changes
Feb 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
73b248d and cba3ae0.