Restrict salt and stored-hash validation to the formats supported by the bundled bcrypt implementation: versions 2a, 2b, 2x, and 2y; costs 04–31; and exact salt/hash lengths. Fixes#133.
Reproduction
The current regexes accept unsupported versions such as $00$/$2z$, costs outside 04–31, and overlong salts. hash_secret then passes these values into the native layer, which returns no hash instead of raising BCrypt::Errors::InvalidSalt; Password.valid_hash? likewise reports structurally unsupported hashes as valid.
Verification
External baseline/fixed model covers all four supported versions, minimum/maximum costs, unsupported versions, costs 03/32/99, overlong salts, stored hashes, and the InvalidSalt boundary.
The complete suite passes 39 examples on Ruby 4.0.6 for both current master and a 3.1.22-based consumer.
All existing Openwall/Spring interoperability vectors remain green.
Limits
JRuby and non-macOS native builds were not executed locally. The accepted formats are derived from both bundled implementations and their existing vectors.
Compatibility
Proper bcrypt salts and hashes are unchanged. Inputs that the native implementation cannot process now fail Ruby validation instead of reaching the native layer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restrict salt and stored-hash validation to the formats supported by the bundled bcrypt implementation: versions 2a, 2b, 2x, and 2y; costs 04–31; and exact salt/hash lengths. Fixes #133.
Reproduction
The current regexes accept unsupported versions such as $00$/$2z$, costs outside 04–31, and overlong salts. hash_secret then passes these values into the native layer, which returns no hash instead of raising BCrypt::Errors::InvalidSalt; Password.valid_hash? likewise reports structurally unsupported hashes as valid.
Verification
Limits
JRuby and non-macOS native builds were not executed locally. The accepted formats are derived from both bundled implementations and their existing vectors.
Compatibility
Proper bcrypt salts and hashes are unchanged. Inputs that the native implementation cannot process now fail Ruby validation instead of reaching the native layer.