require: warn invalid json - #1700
Merged
goto-bus-stop merged 4 commits intoNov 19, 2019
Merged
goto-bus-stop merged 4 commits into
goto-bus-stop merged 4 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
goto-bus-stop
self-requested a review
January 4, 2018 10:20
goto-bus-stop
requested changes
Jan 4, 2018
goto-bus-stop
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
thanks for picking this up! & sorry for the long wait. would you mind rebasing this?
Sorry, something went wrong.
Comment thread
index.js
Outdated
goto-bus-stop
force-pushed
the
master
branch
from
7b5c387 to
5d803b8
Compare
February 16, 2018 14:44
goto-bus-stop
approved these changes
Feb 16, 2018
derrickpatrick6969
approved these changes
Apr 18, 2019
Copy link
Copy Markdown
|
This broke our script that transforms a JSON file to JavaScript file because it is checking the transformed output that is no longer JSON: "$BASEDIR"/node_modules/browserify/bin/cmd.js "$INPUT"/data/data.json -t "$BASEDIR"/scripts/transform.js -o "$DEST"/data.js SyntaxError: While parsing /[...]/data.json: Unexpected token ( in JSON at position 0
at JSON.parse (<anonymous>)
at DestroyableTransform._transform (/home/nike/stuff/mw/jquery.uls/node_modules/browserify/index.js:669:22)
at DestroyableTransform.Transform._read (/home/nike/stuff/mw/jquery.uls/node_modules/readable-stream/lib/_stream_transform.js:184:10)
at DestroyableTransform.Transform._write (/home/nike/stuff/mw/jquery.uls/node_modules/readable-stream/lib/_stream_transform.js:172:83)
at Labeled.Pipeline._write (/home/nike/stuff/mw/jquery.uls/node_modules/stream-splicer/index.js:70:22)
at doWrite (/home/nike/stuff/mw/jquery.uls/node_modules/readable-stream/lib/_stream_writable.js:428:64)
at writeOrBuffer (/home/nike/stuff/mw/jquery.uls/node_modules/readable-stream/lib/_stream_writable.js:417:5)
at Labeled.Writable.write (/home/nike/stuff/mw/jquery.uls/node_modules/readable-stream/lib/_stream_writable.js:334:11)
at Labeled.ondata (/home/nike/stuff/mw/jquery.uls/node_modules/readable-stream/lib/_stream_readable.js:619:20)
at Labeled.emit (events.js:198:13)
Is there a better way to do this? |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1580