FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add Node.js v8 to Travis CI by ryysud · Pull Request #1743 · browserify/browserify · GitHub

  1. browserify
  2. browserify

Repository navigation

Add Node.js v8 to Travis CI - #1743

Merged
goto-bus-stop merged 3 commits into
browserify:masterfrom
ryysud:add-nodejs-v8-to-travis
Jan 4, 2018
ConversationCommits (3)ChecksFiles changed
Merged

Add Node.js v8 to Travis CI#1743
goto-bus-stop merged 3 commits into
browserify:masterfrom
ryysud:add-nodejs-v8-to-travis

Conversation

ryysud commented Jul 2, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

Add support for Node.js v8.
Updated .travis.yml.

hiroppy commented Sep 2, 2017

Copy link
Copy Markdown

I think we can drop 0.12 and 0.10.

ryysud commented Sep 2, 2017

Copy link
Copy Markdown
Contributor Author

@abouthiroppy I think so too.

ryysud commented Sep 2, 2017

Copy link
Copy Markdown
Contributor Author

Please follow up on this 🙇

hiroppy commented Sep 2, 2017

Copy link
Copy Markdown

@substack @maxogden What do you think?

stevemao requested changes Nov 1, 2017
View reviewed changes
Comment thread .travis.yml Outdated
language: node_js
node_js:
- "8"
- "7"

stevemao Nov 1, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

could you remove 7 and add 9?

stevemao commented Nov 1, 2017

Copy link
Copy Markdown
Member

Note this will be a breaking change

ryysud commented Nov 2, 2017

Copy link
Copy Markdown
Contributor Author

@stevemao I fix it.

TehShrike mentioned this pull request Dec 20, 2017
Closed

goto-bus-stop commented Jan 2, 2018

Copy link
Copy Markdown
Member

@ryysud sorry for the wait, curious if you could check out the test failure? it looks like it's a bug in the traceur version used by the yield.js test, maybe bumping the es6ify dependency in our package.json could work?

goto-bus-stop commented Jan 4, 2018

Copy link
Copy Markdown
Member

i'll remove es6ify after merging. thanks for the patch!

goto-bus-stop merged commit 3ccd552 into browserify:master Jan 4, 2018
ryysud deleted the add-nodejs-v8-to-travis branch January 4, 2018 14:14

ljharb commented Jan 6, 2018

Copy link
Copy Markdown
Member

fwiw I think dropping node < 4 was a very very bad move, and I think that should be reverted.

ljharb mentioned this pull request Jan 6, 2018
Merged

ryysud commented Jan 9, 2018

Copy link
Copy Markdown
Contributor Author

@ljharb Sorry. Thank you for your Pull Request 🙇

renovate Bot mentioned this pull request May 22, 2021
Open
1 task
This was referenced Jun 1, 2021
Merged
Open
Open
Open
Open
Open
Closed
renovate Bot mentioned this pull request Jun 14, 2021
Merged
1 task
mend-for-github-com Bot mentioned this pull request Jul 5, 2021
Open
1 task
renovate Bot mentioned this pull request Jul 8, 2021
Open
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

stevemao stevemao approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL