FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Passing tests on Windows and Node 10 by goto-bus-stop · Pull Request #1819 · browserify/browserify · GitHub

Repository navigation

Passing tests on Windows and Node 10 - #1819

Merged
goto-bus-stop merged 6 commits into
browserify:masterfrom
goto-bus-stop:appveyor
May 8, 2018
Merged

goto-bus-stop merged 6 commits into
browserify:masterfrom
goto-bus-stop:appveyor

Conversation

goto-bus-stop commented Mar 22, 2018 •
edited
Loading

Copy link
Copy Markdown
Member
  • Use path.join instead of string concat in some places in tests
  • Change \ to / in paths for external (Fix external relative paths on Windows #1704), ignored and noParse files
  • Skip symlink tests on windows
  • Add an appveyor.yml so we can run tests on windows in the future

goto-bus-stop and others added 3 commits May 8, 2018 10:36
 - Use path.join in more places in tests so they can run on windows

 - Fix noParse check on windows

 - Fix regex in multi_entry test for windows paths

 - Skip symlink tests on windows

 - Fix ignore check on windows

 - Fix paths in noparse and ignore tests on windows.
Replace backslashes with forward slashes when adding relative paths for
external references.
Not sure why this is failing, and can't test it well, so skipping for
now with a TODO comment
goto-bus-stop changed the title Green on Windows Fix tests on Windows and Node 10 May 8, 2018
goto-bus-stop changed the title Fix tests on Windows and Node 10 Passing tests on Windows and Node 10 May 8, 2018
goto-bus-stop merged commit e34599a into browserify:master May 8, 2018
goto-bus-stop deleted the appveyor branch May 8, 2018 12:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL