| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
Eh, I hoped this update could get in as a semver-minor version… I will probably take a look if fixes could be backported to path-browserify@0.0.x. |
Sorry, something went wrong.
Do you have a specific case in mind, btw? That's not applicable to all the methods, as e.g. "
The three methods that didn't throw were: .dirname(), .basename() and .extname(). What do you think of converting the input to string on those and releasing that as path-browserify@0.0.1? |
Sorry, something went wrong.
|
The basename / extname / dirname methods didn't throw in 0.0.0: I think doing a path-browserify release with the fixes and new features but without the additional checks would be fine… |
Sorry, something went wrong.
|
@goto-bus-stop Could I chat with you via IRC or Gitter about it? |
Sorry, something went wrong.
|
Hey folks just wanted to reach out and see if there's anything I can do to help here |
Sorry, something went wrong.
|
For posterity: my concerns above were adressed with a semver-patch version of path-browserify@0.x that backported some of the fixes in a compatible form, so having this update to @1.0.0 a semver-major is fine to me. |
Sorry, something went wrong.
There was a problem hiding this comment.
Sorry, something went wrong.
|
Sorry, something went wrong.
There was a problem hiding this comment.
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
This version updates to the Node v10.3.0 API. This change is breaking,
because path methods now throw errors when called with arguments that are not
strings.
One for v17, maybe. path.XYZ(undefined) throwing an error is definitely going
to break existing projects. I guess they could just stay on older browserify
versions tho.
Closes #1846