| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
There was a problem hiding this comment.
Thanks!
Sorry, something went wrong.
|
You're welcome. Thanks for the quick merge and release! |
Sorry, something went wrong.
|
It might be worth using resolve’s listing of core modules to default all of them to empty (and override with shims as needed) - then this would have Just Worked. |
Sorry, something went wrong.
|
that sounds like a good idea—we've had a few browserify releases lately that were mostly about adding new empty shims. |
Sorry, something went wrong.
|
(Pull in resolve/lib/core, enumerate the entries, and any key whose value is true is a core module in the current node version) |
Sorry, something went wrong.
|
The set of core modules isn’t the same for all Node versions. We might not necessarily build and run on the same version of Node. Maybe we need an extra option to specify the target runtime, e.g. —node-version 10.16.0. |
Sorry, something went wrong.
|
@steve-taylor that’s a reasonable addition to resolve if it’s needed; but i do think that building and running on the same version is typical. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Node.js 10.10.0 added the http2 module. This change adds just enough support for --no-builtins (and therefore --node) to recognise http2 as a Node.js built-in module and not attempt to bundle it.