FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

BREAKING: Update buffer to ^6.0.3 by feross · Pull Request #1988 · browserify/browserify · GitHub

BREAKING: Update buffer to ^6.0.3 - #1988

Open
feross wants to merge 1 commit into
masterfrom
buffer6
Open

feross wants to merge 1 commit into
masterfrom
buffer6

Conversation

feross commented Nov 24, 2020

Copy link
Copy Markdown
Member

Update buffer to ^6.0.3

Browser support

BREAKING: Drop IE11, Safari 9-10 support. This affects ~1.16% of global browser users (source: https://caniuse.com/usage-table) and this number continues to decrease each month.

Since buffer now supports the newly added BigInt methods from Node.js and the implementation uses the exponentiation operator throughout, we decided to drop support for IE11 and Safari 9-10 from buffer.

Similar to previous buffer upgrades (e.g. #1678), users can manually specify an older buffer version if they need IE11 and Safari 9-10 support. More information about how to do this can be found in: #1980

Semver

This should be released as semver major.

BREAKING: Drop IE11, Safari 9-10 support

Since Buffer now supports the BigInt methods and the code for that uses the exponentiation operator, we decided to drop support for IE11 and Safari 9-10 from `buffer`.
feross requested a review from goto-bus-stop November 24, 2020 22:18
andreibancioiu added a commit to multiversx/mx-deprecated-sdk-monorepo that referenced this pull request Dec 1, 2020

Copy link
Copy Markdown
Member

Nice. I think dropping IE 11 is quite a significant step (moreso than any other IE version), so I'd prefer to make it easier to swap out builtins consistently in both the API and CLI before we actually publish this.

feross commented Dec 2, 2020

Copy link
Copy Markdown
Member Author

@goto-bus-stop I think we dropped IE8-10 when it had a similar amount of usage (see: #1678) but if it makes you more comfortable, I'm okay with waiting until usage has declined further or it has become easier to swap out built-ins in the API. :)

Btw, since I sent this PR, IE11 usage has declined from 1.16% to 1.09%. https://caniuse.com/usage-table

ljharb commented Dec 2, 2020

Copy link
Copy Markdown
Member

1% is still 4.6 million people - I'd prefer we don't reduce human beings to percentages.

feross commented Feb 10, 2021

Copy link
Copy Markdown
Member Author

Just a quick note that since I sent this PR, IE11 usage has declined from 1.16% to 1.00%.

@ljharb 1% is still 4.6 million people - I'd prefer we don't reduce human beings to percentages.

Lol, it goes without saying that each human being is unique and special. By that logic, we can't ever drop support for anything because we can't "reduce human beings to percentages". We've dropped support for browsers when they reached similar usage numbers in the past. See: #1678 Also, keep in mind that releasing a new major version of browserify doesn't mean all these users are suddenly abandoned. Developers can decide whether or when to upgrade browserify and drop IE11 support. The current version of browserify will continue working just fine.

ljharb commented Feb 11, 2021

Copy link
Copy Markdown
Member

Unless future features and bugfixes are backported to that version of browserify, it does indeed mean they miss out on those.

goto-bus-stop commented Feb 17, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

I don't think I'll have the time and interest to work on a feature for replacing builtins in plugins in the near future, so maybe the next best thing is to merge this as is and document that users can do npm install buffer@5 and --require buffer/:buffer to maintain support for IE 11.

Copy link
Copy Markdown

0.85% now 😄

Copy link
Copy Markdown

0.76%, we should set the threshold at 0.5%

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL