FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

add async tag and build tags by jfleitz · Pull Request #71 · bytecodealliance/componentize-go · GitHub

/ componentize-go Public

add async tag and build tags - #71

Merged
asteurer merged 2 commits into
bytecodealliance:mainfrom
jfleitz:jfleitz/async-tags
Aug 6, 2026
ConversationCommits (2)ChecksFiles changed
Merged

add async tag and build tags#71
asteurer merged 2 commits into
bytecodealliance:mainfrom
jfleitz:jfleitz/async-tags

Conversation

jfleitz commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Overview

  • Adds support for build tags to be passed
  • Adds a componentizego_async tag when targeting a feature that needs P3/async support (streams, async functions, etc). This can be used in the SDK like ByteCodeAlliance's go package
  • Unit tests for tag derivation (sync vs. async worlds) and GOFLAGS -tags parsing/merging.

Testing

jfleitz added 2 commits July 31, 2026 15:03
add async tag and build tags support
7f55f28 
Signed-off-by: Jeremy Fleitz <jeremy@cosmonic.com>
update test package name to bca
3bb4457 
Signed-off-by: Jeremy Fleitz <jeremy@cosmonic.com>
asteurer approved these changes Aug 2, 2026
View reviewed changes

asteurer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, thanks @jfleitz! I'll give @dicej to look this over before merging.

asteurer merged commit f2f006f into bytecodealliance:main Aug 6, 2026
5 checks passed
dicej reviewed Aug 6, 2026
View reviewed changes

dicej left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Sorry for the late review; LGTM, thanks!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dicej dicej left review comments
asteurer asteurer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL