Exercise clocks and timer polling during imported GC allocations - #78
Draft
carsonfarmer wants to merge 1 commit into
Draft
Exercise clocks and timer polling during imported GC allocations#78carsonfarmer wants to merge 1 commit into
carsonfarmer wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Strengthen the finite memory-pressure fixture with retained large imported strings, an initialized timer, and a GC count assertion. This regression requires the companion preview1 adapter fix before it can pass with the embedded adapter. Co-authored-by: Codex <noreply@openai.com>
This was referenced Sep 11, 2026
Copy link
Copy Markdown
Author
|
The failing macOS job hits cannot leave component instance in poll_oneoff during Go GC—the timer-polling bug this regression is intended to catch. CI still uses the existing embedded adapter. This PR remains a draft until the adapter fix in bytecodealliance/wasmtime#14319 lands and componentize-go updates its embedded adapter. The strengthened test passes locally with that fix; the current CI failure is expected while that dependency is outstanding. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strengthen the memory-pressure test from #60 to catch the remaining GC traps from #56. Retain large imported strings, initialize a timer, and assert that GC ran during the finite workload.
The test fails with the current adapter and passes with the Wasmtime fix on Go 1.26.3 and 1.27.1. Draft until the embedded adapter includes that fix.
Addresses #77.