Implement iterable assertion - #1592
Merged
koddsson merged 4 commits intoFeb 11, 2024
Merged
koddsson merged 4 commits into
koddsson merged 4 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
koddsson
force-pushed
the
introduce-iterable-assertion
branch
from
77ca057 to
c0e6dd7
Compare
January 28, 2024 16:02
koddsson
marked this pull request as ready for review
January 28, 2024 16:06
keithamus
reviewed
Jan 28, 2024
keithamus
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I’m curious why explicitly disallow string for this check?
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
You know, I don't remember why I put that in there. I have a vague memory of the sameMembers test needing this but looking at this in isolations makes me think that's probably a oversight. |
Sorry, something went wrong.
43081j
previously approved these changes
Jan 28, 2024
keithamus
requested changes
Jan 28, 2024
keithamus
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Is this bit meant to be part of this PR?
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Not sure if GitHub is glitching but I can't see what this is referring to. I assume it's the isSubsetOf changes in which case, it shouldn't have been included and I've removed those changes. Thanks :) |
Sorry, something went wrong.
keithamus
previously approved these changes
Jan 29, 2024
keithamus
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I think this is good but I am still a little uneasy about overloading .an() too much.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
curious, do you prefer .is.iterable then? just so we're all on the same page for other changes in future im guessing you're unsure of leaning heavily on an for many things, since over time chai would mostly be that one chain |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
I'd prefer each assertion (especially core assertions) to map to something that a user can reproduce with a single expression. It makes it far easier for us to document, and for users to internalise. If they know .an() is just Chai's shorthand for [Symbol.toStringTag] = then that's an easier way to think about it than having a mental lookup table to some alternative logic. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
makes sense to me 👍 thanks for the explanation, i do agree |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
I'm happy to change this. I'd rather nip this in the bud now than trying to untangle it later. |
Sorry, something went wrong.
keithamus
approved these changes
Feb 11, 2024
keithamus
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Great stuff
Sorry, something went wrong.
renovate Bot
referenced
this pull request
in runtime-env/import-meta-env
Jul 7, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [chai](http://chaijs.com) ([source](https://togithub.com/chaijs/chai)) | [`4.4.1` -> `5.1.1`](https://renovatebot.com/diffs/npm/chai/4.4.1/5.1.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>chaijs/chai (chai)</summary> ### [`v5.1.1`](https://togithub.com/chaijs/chai/releases/tag/v5.1.1) [Compare Source](https://togithub.com/chaijs/chai/compare/v5.1.0...v5.1.1) #### What's Changed - Set up ESLint for JSDoc comments by [@​koddsson](https://togithub.com/koddsson) in [https://github.com/chaijs/chai/pull/1605](https://togithub.com/chaijs/chai/pull/1605) - build(deps-dev): bump ip from 1.1.8 to 1.1.9 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/chaijs/chai/pull/1608](https://togithub.com/chaijs/chai/pull/1608) - Correct Mocha import instructions by [@​MattiSG](https://togithub.com/MattiSG) in [https://github.com/chaijs/chai/pull/1611](https://togithub.com/chaijs/chai/pull/1611) - fix: support some virtual contexts in `toThrow` by [@​43081j](https://togithub.com/43081j) in [https://github.com/chaijs/chai/pull/1609](https://togithub.com/chaijs/chai/pull/1609) #### New Contributors - [@​MattiSG](https://togithub.com/MattiSG) made their first contribution in [https://github.com/chaijs/chai/pull/1611](https://togithub.com/chaijs/chai/pull/1611) **Full Changelog**: chaijs/chai@v5.1.0...v5.1.1 ### [`v5.1.0`](https://togithub.com/chaijs/chai/releases/tag/v5.1.0) [Compare Source](https://togithub.com/chaijs/chai/compare/v5.0.3...v5.1.0) #### What's Changed - Remove useless guards and add parentheses to constuctors by [@​koddsson](https://togithub.com/koddsson) in [https://github.com/chaijs/chai/pull/1593](https://togithub.com/chaijs/chai/pull/1593) - Cleanup jsdoc comments by [@​koddsson](https://togithub.com/koddsson) in [https://github.com/chaijs/chai/pull/1596](https://togithub.com/chaijs/chai/pull/1596) - Convert comments in "legal comments" format to jsdoc or normal comments by [@​koddsson](https://togithub.com/koddsson) in [https://github.com/chaijs/chai/pull/1598](https://togithub.com/chaijs/chai/pull/1598) - Implement `iterable` assertion by [@​koddsson](https://togithub.com/koddsson) in [https://github.com/chaijs/chai/pull/1592](https://togithub.com/chaijs/chai/pull/1592) - Assert interface fix by [@​developer-bandi](https://togithub.com/developer-bandi) in [https://github.com/chaijs/chai/pull/1601](https://togithub.com/chaijs/chai/pull/1601) - Set support in same members by [@​koddsson](https://togithub.com/koddsson) in [https://github.com/chaijs/chai/pull/1583](https://togithub.com/chaijs/chai/pull/1583) - Fix publish script by [@​koddsson](https://togithub.com/koddsson) in [https://github.com/chaijs/chai/pull/1602](https://togithub.com/chaijs/chai/pull/1602) #### New Contributors - [@​developer-bandi](https://togithub.com/developer-bandi) made their first contribution in [https://github.com/chaijs/chai/pull/1601](https://togithub.com/chaijs/chai/pull/1601) **Full Changelog**: chaijs/chai@v5.0.3...v5.1.0 ### [`v5.0.3`](https://togithub.com/chaijs/chai/releases/tag/v5.0.3) [Compare Source](https://togithub.com/chaijs/chai/compare/v5.0.2...v5.0.3) Fix bad v5.0.2 publish. **Full Changelog**: chaijs/chai@v5.0.2...v5.0.3 ### [`v5.0.2`](https://togithub.com/chaijs/chai/releases/tag/v5.0.2) [Compare Source](https://togithub.com/chaijs/chai/compare/v5.0.0...v5.0.2) #### What's Changed - build(deps): bump nanoid and mocha by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/chaijs/chai/pull/1558](https://togithub.com/chaijs/chai/pull/1558) - remove `bump-cli` by [@​koddsson](https://togithub.com/koddsson) in [https://github.com/chaijs/chai/pull/1559](https://togithub.com/chaijs/chai/pull/1559) - Update developer dependencies by [@​koddsson](https://togithub.com/koddsson) in [https://github.com/chaijs/chai/pull/1560](https://togithub.com/chaijs/chai/pull/1560) - fix: removes `??` for node compat (5.x) by [@​43081j](https://togithub.com/43081j) in [https://github.com/chaijs/chai/pull/1576](https://togithub.com/chaijs/chai/pull/1576) - Update `loupe` to latest version by [@​koddsson](https://togithub.com/koddsson) in [https://github.com/chaijs/chai/pull/1579](https://togithub.com/chaijs/chai/pull/1579) - Re-enable some webkit tests by [@​koddsson](https://togithub.com/koddsson) in [https://github.com/chaijs/chai/pull/1580](https://togithub.com/chaijs/chai/pull/1580) - Remove a bunch of if statements in test/should.js by [@​koddsson](https://togithub.com/koddsson) in [https://github.com/chaijs/chai/pull/1581](https://togithub.com/chaijs/chai/pull/1581) - Remove a bunch of unused files by [@​koddsson](https://togithub.com/koddsson) in [https://github.com/chaijs/chai/pull/1582](https://togithub.com/chaijs/chai/pull/1582) - Fix 1564 by [@​koddsson](https://togithub.com/koddsson) in [https://github.com/chaijs/chai/pull/1566](https://togithub.com/chaijs/chai/pull/1566) **Full Changelog**: chaijs/chai@v5.0.1...v5.0.2 ### [`v5.0.0`](https://togithub.com/chaijs/chai/releases/tag/v5.0.0) [Compare Source](https://togithub.com/chaijs/chai/compare/v4.4.1...v5.0.0) #### BREAKING CHANGES - Chai now only supports EcmaScript Modules (ESM). This means your tests will need to either have `import {...} from 'chai'` or `import('chai')`. `require('chai')` will cause failures in nodejs. If you're using ESM and seeing failures, it may be due to a bundler or transpiler which is incorrectly converting import statements into require calls. - Dropped support for Internet Explorer. - Dropped support for NodeJS < 18. - Minimum supported browsers are now Firefox 100, Safari 14.1, Chrome 100, Edge 100. Support for browsers prior to these versions is "best effort" (bug reports on older browsers will be assessed individually and may be marked as wontfix). #### What's Changed - feat: use chaijs/loupe for inspection by [@​pcorpet](https://togithub.com/pcorpet) in [https://github.com/chaijs/chai/pull/1401](https://togithub.com/chaijs/chai/pull/1401) - docs: fix URL in README by [@​Izzur](https://togithub.com/Izzur) in [https://github.com/chaijs/chai/pull/1413](https://togithub.com/chaijs/chai/pull/1413) - Remove `get-func-name` dependency by [@​koddsson](https://togithub.com/koddsson) in [https://github.com/chaijs/chai/pull/1416](https://togithub.com/chaijs/chai/pull/1416) - Convert Makefile script to npm scripts by [@​koddsson](https://togithub.com/koddsson) in [https://github.com/chaijs/chai/pull/1424](https://togithub.com/chaijs/chai/pull/1424) - Clean up README badges by [@​koddsson](https://togithub.com/koddsson) in [https://github.com/chaijs/chai/pull/1422](https://togithub.com/chaijs/chai/pull/1422) - fix: package.json - deprecation warning on exports field by [@​stevenjoezhang](https://togithub.com/stevenjoezhang) in [https://github.com/chaijs/chai/pull/1400](https://togithub.com/chaijs/chai/pull/1400) - fix: deep-eql bump package to support symbols by [@​snewcomer](https://togithub.com/snewcomer) in [https://github.com/chaijs/chai/pull/1458](https://togithub.com/chaijs/chai/pull/1458) - ES module conversion PoC by [@​43081j](https://togithub.com/43081j) in [https://github.com/chaijs/chai/pull/1498](https://togithub.com/chaijs/chai/pull/1498) - chore: drop commonjs support by [@​43081j](https://togithub.com/43081j) in [https://github.com/chaijs/chai/pull/1503](https://togithub.com/chaijs/chai/pull/1503) - Update pathval by [@​koddsson](https://togithub.com/koddsson) in [https://github.com/chaijs/chai/pull/1527](https://togithub.com/chaijs/chai/pull/1527) - Update check-error by [@​koddsson](https://togithub.com/koddsson) in [https://github.com/chaijs/chai/pull/1528](https://togithub.com/chaijs/chai/pull/1528) - update `deep-eql` to latest version by [@​koddsson](https://togithub.com/koddsson) in [https://github.com/chaijs/chai/pull/1542](https://togithub.com/chaijs/chai/pull/1542) - Inline `type-detect` as a simple function by [@​koddsson](https://togithub.com/koddsson) in [https://github.com/chaijs/chai/pull/1544](https://togithub.com/chaijs/chai/pull/1544) - Update loupe by [@​koddsson](https://togithub.com/koddsson) in [https://github.com/chaijs/chai/pull/1545](https://togithub.com/chaijs/chai/pull/1545) - Typo 'Test an object' not 'Test and object' by [@​mavaddat](https://togithub.com/mavaddat) in [https://github.com/chaijs/chai/pull/1460](https://togithub.com/chaijs/chai/pull/1460) - Update `assertion-error` to it's latest major version! by [@​koddsson](https://togithub.com/koddsson) in [https://github.com/chaijs/chai/pull/1543](https://togithub.com/chaijs/chai/pull/1543) - Replacing Karma with Web Test Runner by [@​koddsson](https://togithub.com/koddsson) in [https://github.com/chaijs/chai/pull/1546](https://togithub.com/chaijs/chai/pull/1546) #### New Contributors - [@​Izzur](https://togithub.com/Izzur) made their first contribution in [https://github.com/chaijs/chai/pull/1413](https://togithub.com/chaijs/chai/pull/1413) - [@​stevenjoezhang](https://togithub.com/stevenjoezhang) made their first contribution in [https://github.com/chaijs/chai/pull/1400](https://togithub.com/chaijs/chai/pull/1400) - [@​43081j](https://togithub.com/43081j) made their first contribution in [https://github.com/chaijs/chai/pull/1498](https://togithub.com/chaijs/chai/pull/1498) **Full Changelog**: chaijs/chai@4.3.1...v5.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/runtime-env/import-meta-env). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjEuOSIsInVwZGF0ZWRJblZlciI6IjM3LjQyMS45IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
solaris007
referenced
this pull request
in adobe/spacecat-shared
Aug 27, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---|---|---| | [actions/setup-java](https://togithub.com/actions/setup-java) | action | major | `v3` -> `v4` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [chai](http://chaijs.com) ([source](https://togithub.com/chaijs/chai)) | devDependencies | major | [`4.5.0` -> `5.1.1`](https://renovatebot.com/diffs/npm/chai/4.5.0/5.1.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>actions/setup-java (actions/setup-java)</summary> ### [`v4`](https://togithub.com/actions/setup-java/compare/v3...v4) [Compare Source](https://togithub.com/actions/setup-java/compare/v3...v4) </details> <details> <summary>chaijs/chai (chai)</summary> ### [`v5.1.1`](https://togithub.com/chaijs/chai/releases/tag/v5.1.1) [Compare Source](https://togithub.com/chaijs/chai/compare/v5.1.0...v5.1.1) #### What's Changed - Set up ESLint for JSDoc comments by [@​koddsson](https://togithub.com/koddsson) in [https://github.com/chaijs/chai/pull/1605](https://togithub.com/chaijs/chai/pull/1605) - build(deps-dev): bump ip from 1.1.8 to 1.1.9 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/chaijs/chai/pull/1608](https://togithub.com/chaijs/chai/pull/1608) - Correct Mocha import instructions by [@​MattiSG](https://togithub.com/MattiSG) in [https://github.com/chaijs/chai/pull/1611](https://togithub.com/chaijs/chai/pull/1611) - fix: support some virtual contexts in `toThrow` by [@​43081j](https://togithub.com/43081j) in [https://github.com/chaijs/chai/pull/1609](https://togithub.com/chaijs/chai/pull/1609) #### New Contributors - [@​MattiSG](https://togithub.com/MattiSG) made their first contribution in [https://github.com/chaijs/chai/pull/1611](https://togithub.com/chaijs/chai/pull/1611) **Full Changelog**: chaijs/chai@v5.1.0...v5.1.1 ### [`v5.1.0`](https://togithub.com/chaijs/chai/releases/tag/v5.1.0) [Compare Source](https://togithub.com/chaijs/chai/compare/v5.0.3...v5.1.0) #### What's Changed - Remove useless guards and add parentheses to constuctors by [@​koddsson](https://togithub.com/koddsson) in [https://github.com/chaijs/chai/pull/1593](https://togithub.com/chaijs/chai/pull/1593) - Cleanup jsdoc comments by [@​koddsson](https://togithub.com/koddsson) in [https://github.com/chaijs/chai/pull/1596](https://togithub.com/chaijs/chai/pull/1596) - Convert comments in "legal comments" format to jsdoc or normal comments by [@​koddsson](https://togithub.com/koddsson) in [https://github.com/chaijs/chai/pull/1598](https://togithub.com/chaijs/chai/pull/1598) - Implement `iterable` assertion by [@​koddsson](https://togithub.com/koddsson) in [https://github.com/chaijs/chai/pull/1592](https://togithub.com/chaijs/chai/pull/1592) - Assert interface fix by [@​developer-bandi](https://togithub.com/developer-bandi) in [https://github.com/chaijs/chai/pull/1601](https://togithub.com/chaijs/chai/pull/1601) - Set support in same members by [@​koddsson](https://togithub.com/koddsson) in [https://github.com/chaijs/chai/pull/1583](https://togithub.com/chaijs/chai/pull/1583) - Fix publish script by [@​koddsson](https://togithub.com/koddsson) in [https://github.com/chaijs/chai/pull/1602](https://togithub.com/chaijs/chai/pull/1602) #### New Contributors - [@​developer-bandi](https://togithub.com/developer-bandi) made their first contribution in [https://github.com/chaijs/chai/pull/1601](https://togithub.com/chaijs/chai/pull/1601) **Full Changelog**: chaijs/chai@v5.0.3...v5.1.0 ### [`v5.0.3`](https://togithub.com/chaijs/chai/releases/tag/v5.0.3) [Compare Source](https://togithub.com/chaijs/chai/compare/v5.0.2...v5.0.3) Fix bad v5.0.2 publish. **Full Changelog**: chaijs/chai@v5.0.2...v5.0.3 ### [`v5.0.2`](https://togithub.com/chaijs/chai/releases/tag/v5.0.2) [Compare Source](https://togithub.com/chaijs/chai/compare/v5.0.0...v5.0.2) #### What's Changed - build(deps): bump nanoid and mocha by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/chaijs/chai/pull/1558](https://togithub.com/chaijs/chai/pull/1558) - remove `bump-cli` by [@​koddsson](https://togithub.com/koddsson) in [https://github.com/chaijs/chai/pull/1559](https://togithub.com/chaijs/chai/pull/1559) - Update developer dependencies by [@​koddsson](https://togithub.com/koddsson) in [https://github.com/chaijs/chai/pull/1560](https://togithub.com/chaijs/chai/pull/1560) - fix: removes `??` for node compat (5.x) by [@​43081j](https://togithub.com/43081j) in [https://github.com/chaijs/chai/pull/1576](https://togithub.com/chaijs/chai/pull/1576) - Update `loupe` to latest version by [@​koddsson](https://togithub.com/koddsson) in [https://github.com/chaijs/chai/pull/1579](https://togithub.com/chaijs/chai/pull/1579) - Re-enable some webkit tests by [@​koddsson](https://togithub.com/koddsson) in [https://github.com/chaijs/chai/pull/1580](https://togithub.com/chaijs/chai/pull/1580) - Remove a bunch of if statements in test/should.js by [@​koddsson](https://togithub.com/koddsson) in [https://github.com/chaijs/chai/pull/1581](https://togithub.com/chaijs/chai/pull/1581) - Remove a bunch of unused files by [@​koddsson](https://togithub.com/koddsson) in [https://github.com/chaijs/chai/pull/1582](https://togithub.com/chaijs/chai/pull/1582) - Fix 1564 by [@​koddsson](https://togithub.com/koddsson) in [https://github.com/chaijs/chai/pull/1566](https://togithub.com/chaijs/chai/pull/1566) **Full Changelog**: chaijs/chai@v5.0.1...v5.0.2 ### [`v5.0.0`](https://togithub.com/chaijs/chai/releases/tag/v5.0.0) [Compare Source](https://togithub.com/chaijs/chai/compare/v4.5.0...v5.0.0) #### BREAKING CHANGES - Chai now only supports EcmaScript Modules (ESM). This means your tests will need to either have `import {...} from 'chai'` or `import('chai')`. `require('chai')` will cause failures in nodejs. If you're using ESM and seeing failures, it may be due to a bundler or transpiler which is incorrectly converting import statements into require calls. - Dropped support for Internet Explorer. - Dropped support for NodeJS < 18. - Minimum supported browsers are now Firefox 100, Safari 14.1, Chrome 100, Edge 100. Support for browsers prior to these versions is "best effort" (bug reports on older browsers will be assessed individually and may be marked as wontfix). #### What's Changed - feat: use chaijs/loupe for inspection by [@​pcorpet](https://togithub.com/pcorpet) in [https://github.com/chaijs/chai/pull/1401](https://togithub.com/chaijs/chai/pull/1401) - docs: fix URL in README by [@​Izzur](https://togithub.com/Izzur) in [https://github.com/chaijs/chai/pull/1413](https://togithub.com/chaijs/chai/pull/1413) - Remove `get-func-name` dependency by [@​koddsson](https://togithub.com/koddsson) in [https://github.com/chaijs/chai/pull/1416](https://togithub.com/chaijs/chai/pull/1416) - Convert Makefile script to npm scripts by [@​koddsson](https://togithub.com/koddsson) in [https://github.com/chaijs/chai/pull/1424](https://togithub.com/chaijs/chai/pull/1424) - Clean up README badges by [@​koddsson](https://togithub.com/koddsson) in [https://github.com/chaijs/chai/pull/1422](https://togithub.com/chaijs/chai/pull/1422) - fix: package.json - deprecation warning on exports field by [@​stevenjoezhang](https://togithub.com/stevenjoezhang) in [https://github.com/chaijs/chai/pull/1400](https://togithub.com/chaijs/chai/pull/1400) - fix: deep-eql bump package to support symbols by [@​snewcomer](https://togithub.com/snewcomer) in [https://github.com/chaijs/chai/pull/1458](https://togithub.com/chaijs/chai/pull/1458) - ES module conversion PoC by [@​43081j](https://togithub.com/43081j) in [https://github.com/chaijs/chai/pull/1498](https://togithub.com/chaijs/chai/pull/1498) - chore: drop commonjs support by [@​43081j](https://togithub.com/43081j) in [https://github.com/chaijs/chai/pull/1503](https://togithub.com/chaijs/chai/pull/1503) - Update pathval by [@​koddsson](https://togithub.com/koddsson) in [https://github.com/chaijs/chai/pull/1527](https://togithub.com/chaijs/chai/pull/1527) - Update check-error by [@​koddsson](https://togithub.com/koddsson) in [https://github.com/chaijs/chai/pull/1528](https://togithub.com/chaijs/chai/pull/1528) - update `deep-eql` to latest version by [@​koddsson](https://togithub.com/koddsson) in [https://github.com/chaijs/chai/pull/1542](https://togithub.com/chaijs/chai/pull/1542) - Inline `type-detect` as a simple function by [@​koddsson](https://togithub.com/koddsson) in [https://github.com/chaijs/chai/pull/1544](https://togithub.com/chaijs/chai/pull/1544) - Update loupe by [@​koddsson](https://togithub.com/koddsson) in [https://github.com/chaijs/chai/pull/1545](https://togithub.com/chaijs/chai/pull/1545) - Typo 'Test an object' not 'Test and object' by [@​mavaddat](https://togithub.com/mavaddat) in [https://github.com/chaijs/chai/pull/1460](https://togithub.com/chaijs/chai/pull/1460) - Update `assertion-error` to it's latest major version! by [@​koddsson](https://togithub.com/koddsson) in [https://github.com/chaijs/chai/pull/1543](https://togithub.com/chaijs/chai/pull/1543) - Replacing Karma with Web Test Runner by [@​koddsson](https://togithub.com/koddsson) in [https://github.com/chaijs/chai/pull/1546](https://togithub.com/chaijs/chai/pull/1546) #### New Contributors - [@​Izzur](https://togithub.com/Izzur) made their first contribution in [https://github.com/chaijs/chai/pull/1413](https://togithub.com/chaijs/chai/pull/1413) - [@​stevenjoezhang](https://togithub.com/stevenjoezhang) made their first contribution in [https://github.com/chaijs/chai/pull/1400](https://togithub.com/chaijs/chai/pull/1400) - [@​43081j](https://togithub.com/43081j) made their first contribution in [https://github.com/chaijs/chai/pull/1498](https://togithub.com/chaijs/chai/pull/1498) **Full Changelog**: chaijs/chai@4.3.1...v5.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 2pm on Monday" in timezone Europe/Zurich, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/adobe/spacecat-shared). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Dominique Jäggi <1872195+solaris007@users.noreply.github.com>
This was referenced Sep 10, 2024
This was referenced Sep 12, 2024
renovate Bot
referenced
this pull request
in davidsneighbour/hugo-modules
Sep 14, 2024
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [chai](http://chaijs.com) ([source](https://redirect.github.com/chaijs/chai)) | [`^4.5.0` -> `^5.0.0`](https://renovatebot.com/diffs/npm/chai/4.5.0/5.1.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>chaijs/chai (chai)</summary> ### [`v5.1.1`](https://redirect.github.com/chaijs/chai/releases/tag/v5.1.1) [Compare Source](https://redirect.github.com/chaijs/chai/compare/v5.1.0...v5.1.1) #### What's Changed - Set up ESLint for JSDoc comments by [@​koddsson](https://redirect.github.com/koddsson) in [https://github.com/chaijs/chai/pull/1605](https://redirect.github.com/chaijs/chai/pull/1605) - build(deps-dev): bump ip from 1.1.8 to 1.1.9 by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/chaijs/chai/pull/1608](https://redirect.github.com/chaijs/chai/pull/1608) - Correct Mocha import instructions by [@​MattiSG](https://redirect.github.com/MattiSG) in [https://github.com/chaijs/chai/pull/1611](https://redirect.github.com/chaijs/chai/pull/1611) - fix: support some virtual contexts in `toThrow` by [@​43081j](https://redirect.github.com/43081j) in [https://github.com/chaijs/chai/pull/1609](https://redirect.github.com/chaijs/chai/pull/1609) #### New Contributors - [@​MattiSG](https://redirect.github.com/MattiSG) made their first contribution in [https://github.com/chaijs/chai/pull/1611](https://redirect.github.com/chaijs/chai/pull/1611) **Full Changelog**: chaijs/chai@v5.1.0...v5.1.1 ### [`v5.1.0`](https://redirect.github.com/chaijs/chai/releases/tag/v5.1.0) [Compare Source](https://redirect.github.com/chaijs/chai/compare/v5.0.3...v5.1.0) #### What's Changed - Remove useless guards and add parentheses to constuctors by [@​koddsson](https://redirect.github.com/koddsson) in [https://github.com/chaijs/chai/pull/1593](https://redirect.github.com/chaijs/chai/pull/1593) - Cleanup jsdoc comments by [@​koddsson](https://redirect.github.com/koddsson) in [https://github.com/chaijs/chai/pull/1596](https://redirect.github.com/chaijs/chai/pull/1596) - Convert comments in "legal comments" format to jsdoc or normal comments by [@​koddsson](https://redirect.github.com/koddsson) in [https://github.com/chaijs/chai/pull/1598](https://redirect.github.com/chaijs/chai/pull/1598) - Implement `iterable` assertion by [@​koddsson](https://redirect.github.com/koddsson) in [https://github.com/chaijs/chai/pull/1592](https://redirect.github.com/chaijs/chai/pull/1592) - Assert interface fix by [@​developer-bandi](https://redirect.github.com/developer-bandi) in [https://github.com/chaijs/chai/pull/1601](https://redirect.github.com/chaijs/chai/pull/1601) - Set support in same members by [@​koddsson](https://redirect.github.com/koddsson) in [https://github.com/chaijs/chai/pull/1583](https://redirect.github.com/chaijs/chai/pull/1583) - Fix publish script by [@​koddsson](https://redirect.github.com/koddsson) in [https://github.com/chaijs/chai/pull/1602](https://redirect.github.com/chaijs/chai/pull/1602) #### New Contributors - [@​developer-bandi](https://redirect.github.com/developer-bandi) made their first contribution in [https://github.com/chaijs/chai/pull/1601](https://redirect.github.com/chaijs/chai/pull/1601) **Full Changelog**: chaijs/chai@v5.0.3...v5.1.0 ### [`v5.0.3`](https://redirect.github.com/chaijs/chai/releases/tag/v5.0.3) [Compare Source](https://redirect.github.com/chaijs/chai/compare/v5.0.2...v5.0.3) Fix bad v5.0.2 publish. **Full Changelog**: chaijs/chai@v5.0.2...v5.0.3 ### [`v5.0.2`](https://redirect.github.com/chaijs/chai/releases/tag/v5.0.2) [Compare Source](https://redirect.github.com/chaijs/chai/compare/v5.0.0...v5.0.2) #### What's Changed - build(deps): bump nanoid and mocha by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/chaijs/chai/pull/1558](https://redirect.github.com/chaijs/chai/pull/1558) - remove `bump-cli` by [@​koddsson](https://redirect.github.com/koddsson) in [https://github.com/chaijs/chai/pull/1559](https://redirect.github.com/chaijs/chai/pull/1559) - Update developer dependencies by [@​koddsson](https://redirect.github.com/koddsson) in [https://github.com/chaijs/chai/pull/1560](https://redirect.github.com/chaijs/chai/pull/1560) - fix: removes `??` for node compat (5.x) by [@​43081j](https://redirect.github.com/43081j) in [https://github.com/chaijs/chai/pull/1576](https://redirect.github.com/chaijs/chai/pull/1576) - Update `loupe` to latest version by [@​koddsson](https://redirect.github.com/koddsson) in [https://github.com/chaijs/chai/pull/1579](https://redirect.github.com/chaijs/chai/pull/1579) - Re-enable some webkit tests by [@​koddsson](https://redirect.github.com/koddsson) in [https://github.com/chaijs/chai/pull/1580](https://redirect.github.com/chaijs/chai/pull/1580) - Remove a bunch of if statements in test/should.js by [@​koddsson](https://redirect.github.com/koddsson) in [https://github.com/chaijs/chai/pull/1581](https://redirect.github.com/chaijs/chai/pull/1581) - Remove a bunch of unused files by [@​koddsson](https://redirect.github.com/koddsson) in [https://github.com/chaijs/chai/pull/1582](https://redirect.github.com/chaijs/chai/pull/1582) - Fix 1564 by [@​koddsson](https://redirect.github.com/koddsson) in [https://github.com/chaijs/chai/pull/1566](https://redirect.github.com/chaijs/chai/pull/1566) **Full Changelog**: chaijs/chai@v5.0.1...v5.0.2 ### [`v5.0.0`](https://redirect.github.com/chaijs/chai/releases/tag/v5.0.0) [Compare Source](https://redirect.github.com/chaijs/chai/compare/v4.5.0...v5.0.0) #### BREAKING CHANGES - Chai now only supports EcmaScript Modules (ESM). This means your tests will need to either have `import {...} from 'chai'` or `import('chai')`. `require('chai')` will cause failures in nodejs. If you're using ESM and seeing failures, it may be due to a bundler or transpiler which is incorrectly converting import statements into require calls. - Dropped support for Internet Explorer. - Dropped support for NodeJS < 18. - Minimum supported browsers are now Firefox 100, Safari 14.1, Chrome 100, Edge 100. Support for browsers prior to these versions is "best effort" (bug reports on older browsers will be assessed individually and may be marked as wontfix). #### What's Changed - feat: use chaijs/loupe for inspection by [@​pcorpet](https://redirect.github.com/pcorpet) in [https://github.com/chaijs/chai/pull/1401](https://redirect.github.com/chaijs/chai/pull/1401) - docs: fix URL in README by [@​Izzur](https://redirect.github.com/Izzur) in [https://github.com/chaijs/chai/pull/1413](https://redirect.github.com/chaijs/chai/pull/1413) - Remove `get-func-name` dependency by [@​koddsson](https://redirect.github.com/koddsson) in [https://github.com/chaijs/chai/pull/1416](https://redirect.github.com/chaijs/chai/pull/1416) - Convert Makefile script to npm scripts by [@​koddsson](https://redirect.github.com/koddsson) in [https://github.com/chaijs/chai/pull/1424](https://redirect.github.com/chaijs/chai/pull/1424) - Clean up README badges by [@​koddsson](https://redirect.github.com/koddsson) in [https://github.com/chaijs/chai/pull/1422](https://redirect.github.com/chaijs/chai/pull/1422) - fix: package.json - deprecation warning on exports field by [@​stevenjoezhang](https://redirect.github.com/stevenjoezhang) in [https://github.com/chaijs/chai/pull/1400](https://redirect.github.com/chaijs/chai/pull/1400) - fix: deep-eql bump package to support symbols by [@​snewcomer](https://redirect.github.com/snewcomer) in [https://github.com/chaijs/chai/pull/1458](https://redirect.github.com/chaijs/chai/pull/1458) - ES module conversion PoC by [@​43081j](https://redirect.github.com/43081j) in [https://github.com/chaijs/chai/pull/1498](https://redirect.github.com/chaijs/chai/pull/1498) - chore: drop commonjs support by [@​43081j](https://redirect.github.com/43081j) in [https://github.com/chaijs/chai/pull/1503](https://redirect.github.com/chaijs/chai/pull/1503) - Update pathval by [@​koddsson](https://redirect.github.com/koddsson) in [https://github.com/chaijs/chai/pull/1527](https://redirect.github.com/chaijs/chai/pull/1527) - Update check-error by [@​koddsson](https://redirect.github.com/koddsson) in [https://github.com/chaijs/chai/pull/1528](https://redirect.github.com/chaijs/chai/pull/1528) - update `deep-eql` to latest version by [@​koddsson](https://redirect.github.com/koddsson) in [https://github.com/chaijs/chai/pull/1542](https://redirect.github.com/chaijs/chai/pull/1542) - Inline `type-detect` as a simple function by [@​koddsson](https://redirect.github.com/koddsson) in [https://github.com/chaijs/chai/pull/1544](https://redirect.github.com/chaijs/chai/pull/1544) - Update loupe by [@​koddsson](https://redirect.github.com/koddsson) in [https://github.com/chaijs/chai/pull/1545](https://redirect.github.com/chaijs/chai/pull/1545) - Typo 'Test an object' not 'Test and object' by [@​mavaddat](https://redirect.github.com/mavaddat) in [https://github.com/chaijs/chai/pull/1460](https://redirect.github.com/chaijs/chai/pull/1460) - Update `assertion-error` to it's latest major version! by [@​koddsson](https://redirect.github.com/koddsson) in [https://github.com/chaijs/chai/pull/1543](https://redirect.github.com/chaijs/chai/pull/1543) - Replacing Karma with Web Test Runner by [@​koddsson](https://redirect.github.com/koddsson) in [https://github.com/chaijs/chai/pull/1546](https://redirect.github.com/chaijs/chai/pull/1546) #### New Contributors - [@​Izzur](https://redirect.github.com/Izzur) made their first contribution in [https://github.com/chaijs/chai/pull/1413](https://redirect.github.com/chaijs/chai/pull/1413) - [@​stevenjoezhang](https://redirect.github.com/stevenjoezhang) made their first contribution in [https://github.com/chaijs/chai/pull/1400](https://redirect.github.com/chaijs/chai/pull/1400) - [@​43081j](https://redirect.github.com/43081j) made their first contribution in [https://github.com/chaijs/chai/pull/1498](https://redirect.github.com/chaijs/chai/pull/1498) **Full Changelog**: chaijs/chai@4.3.1...v5.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/davidsneighbour/hugo-modules). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC43NC4xIiwidXBkYXRlZEluVmVyIjoiMzguNzQuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This was referenced Nov 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulled this out of #1583 so that these PRs make more logical sense.
This PR implemensts a iterable/isIterable assertion that checks a given object for Symbol.iterator but notably excludes string which does have Symbol.iterator but we don't consider to be "iterable".