FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Install.rst: Add link for the Docker documentation by rohanrajpal · Pull Request #590 · coala/documentation · GitHub

/ documentation Public

Install.rst: Add link for the Docker documentation - #590

Open
rohanrajpal wants to merge 1 commit into
coala:masterfrom
rohanrajpal:my-first-good-pull-request
ConversationCommits (1)ChecksFiles changed
Open

Install.rst: Add link for the Docker documentation#590
rohanrajpal wants to merge 1 commit into
coala:masterfrom
rohanrajpal:my-first-good-pull-request

Conversation

rohanrajpal commented Jan 9, 2019 •
edited
Loading

Copy link
Copy Markdown

Adds the link for the Coala Docker documentation giving
users more information on how to use Coala with Docker.

Closes #588

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

  • I read the commit guidelines and I've followed
    them.
  • I ran coala over my code locally. (All commits have to pass
    individually.     It is not sufficient to have "fixup commits" on your PR,
    our bot will still report the issues for the previous commit.) You will
    likely receive a lot of bot comments and build failures if coala does not
    pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

budukhyash approved these changes Jan 9, 2019
View reviewed changes

budukhyash left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM 👍 Great work for a first PR !!

shashank-b suggested changes Jan 10, 2019
View reviewed changes
Comment thread Users/Install.rst Outdated
rohanrajpal force-pushed the my-first-good-pull-request branch from 99328c5 to 8a08b44 Compare January 10, 2019 12:48
li-boxuan requested changes Jan 10, 2019
View reviewed changes

li-boxuan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Check your commit message, coala is always written with a small 'c' 😉

Comment thread Users/Install.rst Outdated
rohanrajpal force-pushed the my-first-good-pull-request branch from 8a08b44 to 24eed15 Compare January 10, 2019 13:49

rohanrajpal commented Jan 11, 2019

Copy link
Copy Markdown
Author

@budukhyash thanks for reviewing!
@shashank-b @li-boxuan I've resolved the issues, can you both review it again?

rohanrajpal commented Jan 12, 2019

Copy link
Copy Markdown
Author

@shashank-b thanks for approving. Who else needs to accept this PR so that it gets merged?

shashank-b commented Jan 12, 2019

Copy link
Copy Markdown
Member

Once one of the maintainers approve it, you can start working on other issues, and the maintainers would merge it when appropriate.

utkarsh2102 approved these changes Jan 14, 2019
View reviewed changes

utkarsh2102 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM :)

jayvdb requested changes Jan 31, 2019
View reviewed changes
Comment thread Users/Install.rst Outdated
Install.rst: Add link for the Docker documentation
75f71f0 
Adds the link for the coala Docker documentation giving
users more information on how to use coala with Docker.

Closes coala#588
rohanrajpal force-pushed the my-first-good-pull-request branch from 24eed15 to 75f71f0 Compare February 2, 2019 13:47
jayvdb requested changes Feb 3, 2019
View reviewed changes
Comment thread Users/Install.rst
=======================

Don't know what Docker is? Have a look at
`What is Docker? <Docker_Image.html>`_

jayvdb Feb 3, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Use just <Docker_Image> - sphinx will automatically add the .html

rohanrajpal Feb 3, 2019 •
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I did that but I'm getting ERR_FILE_NOT_FOUND when I click on the link. I'm using Sphinx v1.6.5

rohanrajpal Feb 3, 2019

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Basically it's not automatically adding the HTML for me.

rohanrajpal Feb 7, 2019

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@jayvdb any suggestions?

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jayvdb jayvdb requested changes
li-boxuan li-boxuan approved these changes
+4 more reviewers
budukhyash budukhyash approved these changes
shashank-b shashank-b approved these changes
utkarsh2102 utkarsh2102 approved these changes
xurror xurror approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

rohanrajpal

Labels

area/documentation process/wip size/XS

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improvement in the Installation guide ( Docker Part )

8 participants

Back | FazBrowse Home | New Git URL