Skip excluded functions in LCOV function totals - #2206
Merged
nedbat merged 3 commits intoJun 27, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
nedbat
reviewed
Jun 23, 2026
Comment thread
coverage/lcovreport.py
Outdated
|
|
||
| outfile.write(f"FNF:{len(functions)}\n") | ||
| outfile.write(f"FNH:{functions_hit}\n") | ||
| if functions_found: |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Are you sure we should omit these lines if no functions are found/hit? Wouldn't it be better to output FNF:0 ?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
I believe you are correct, I also added a regression test to assert this behaviour.
Sorry, something went wrong.
nedbat
force-pushed
the
fix-lcov-excluded-functions
branch
from
4a80c04 to
d4e185a
Compare
June 27, 2026 16:20
Copy link
Copy Markdown
Member
|
This is now released as part of coverage 7.15.0. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2205.
Summary
Details
Line records already respect report exclusions. Function records were still generated from all discovered function code regions, so a fully excluded abstract method could appear as FNDA:0 and reduce downstream LCOV function coverage even when the text report shows 100% line coverage.
This narrows each function region before emission and skips regions with n_statements == 0, matching the line-reporting behavior for fully excluded code.
Tests