POC - Handle when Worker is unsupported - #20
Open
Conrad2134 wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Conrad2134
commented
Jan 24, 2018
Comment thread
src/index.js
| // TODO: Is this the full API? Do we need to add anything else? | ||
| worker = { | ||
| kill() {}, | ||
| terminate() {}, |
Copy link
Copy Markdown
Author
There was a problem hiding this comment.
Should we implement these methods to remove the proxied methods on the worker? Or fine as no-op?
Sorry, something went wrong.
Copy link
Copy Markdown
Owner
There was a problem hiding this comment.
TBH I'm tempted to not even emulate these since they do nothing. Doing an existence-test for worker.terminate would be a decent way to know if the worker got inlined or not.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to show that falling back to the main thread when Workers aren't supported works. There's a lot of TODOs because I wasn't sure the best way to go about a couple of things.
Bundles: