| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
Allow UpdateServiceCmd to forward registry credentials through the X-Registry-Auth header. Cover header serialization with focused tests and verify service updates can pull an image from an authenticated private registry.
|
@eddumelendez Please review when you have a moment. Thank you. |
Sorry, something went wrong.
|
@eddumelendez Hi just wanted to ping you on this. Will you have a chance to review this? |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Summary
Adds registry authentication support to UpdateServiceCmd, bringing service updates in line with the authentication support already available when creating services.
Problem
A service update can change its container image. When the new image is hosted in a private registry, Docker requires registry credentials in the X-Registry-Auth request header. UpdateServiceCmd did not expose an AuthConfig option, so callers could not provide those credentials and Swarm could not pull the private image during an update.
Implementation
Running the registry in the Swarm Docker-in-Docker daemon is important because localhost:5050 must resolve to the registry from the worker performing the image pull.
Compatibility
Verification
The executor tests verify both the serialized authentication header and its omission when authentication is not configured.
The integration test starts a service with a public image, pushes that image to an authenticated local registry, removes the local private-image tag, and then updates the service with AuthConfig. It waits until the replacement Swarm task is running the private image, ensuring the update really authenticated and pulled from the registry.