FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: support for brotli by bjohansebas · Pull Request #194 · expressjs/compression · GitHub

/ compression Public

feat: support for brotli - #194

Merged
wesleytodd merged 36 commits into
expressjs:masterfrom
bjohansebas:feature/brotli
Jan 8, 2025
ConversationCommits (36)ChecksFiles changed
Merged

feat: support for brotli#194
wesleytodd merged 36 commits into
expressjs:masterfrom
bjohansebas:feature/brotli

Conversation

bjohansebas commented Oct 19, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

The changes from #172 are brought in, with the exception of using the accept negotiation logic.

danielgindi and others added 18 commits July 10, 2020 12:47
Added support for brotli ('br') content-encoding
5bdbb9e
Update README.md
6ef8cef
Update README.md
02c06c2
Update README.md
4df713b
Apply default value also when params is specified
87076af
Increase coverage for specifying params
fffe4c7
Updated brotli detection method
9145a55
Prefer br over gzip and deflate
0bb402e
feat: use "koa-compress" logic to determine the preferred encoding
bbcd9c4
test: adding one more test case br/gzip with quality params
767c62a
chore: fix linting errors
78ad84a
fix: hand write encodings lib to be compatible with node 0.8
4c359b8
Fix: fixing lint errors in new lib
8340cde
Fix: fixing lint errors in new lib
04ab713
implemented required encoding negotiator without 3rd party dependency
b024cce
Merge branch 'master' into feature/brotli
9af45dd
fix
25b68b8
use negotiator
3d30ab0

bjohansebas commented Oct 19, 2024

Copy link
Copy Markdown
Member Author

It should use accepts, so this PR is not ready yet, and I don't have the option to turn it into a draft. I will soon open a PR in accepts to be able to use this logic

bjohansebas self-assigned this Oct 19, 2024
UlisesGascon requested a review from a team October 20, 2024 17:24
bjohansebas marked this pull request as draft October 22, 2024 21:07
bjohansebas mentioned this pull request Oct 22, 2024
Closed
blakeembrey approved these changes Oct 23, 2024
View reviewed changes
Comment thread encoding_negotiator.js Outdated
bjohansebas marked this pull request as ready for review October 24, 2024 00:17
blakeembrey mentioned this pull request Oct 24, 2024
Merged

bjohansebas commented Dec 1, 2024

Copy link
Copy Markdown
Member Author

I really don't think there are any more changes to be made here.

This comment was marked as outdated.

Sign in to view
bjohansebas marked this pull request as draft December 5, 2024 16:51
bjohansebas marked this pull request as ready for review December 5, 2024 19:13
nscuilla-godaddy reviewed Dec 6, 2024
View reviewed changes
Comment thread index.js Outdated
blakeembrey reviewed Dec 6, 2024
View reviewed changes
Comment thread index.js
This was referenced Dec 17, 2024
Closed
Closed

Kle0s commented Dec 23, 2024

Copy link
Copy Markdown

@wesleytodd any chance you have the time to review it once again so it could be merged?

kapilaggar commented Dec 29, 2024

Copy link
Copy Markdown

@bjohansebas @blakeembrey any idea when this PR will be merged and new version will be released?

github-actions Bot mentioned this pull request Dec 31, 2024
Closed
wesleytodd approved these changes Jan 8, 2025
View reviewed changes

wesleytodd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. Lets merge and I will add this to the list of thing to prepare releases for in the next few weeks.

wesleytodd merged commit d272132 into expressjs:master Jan 8, 2025
bjohansebas deleted the feature/brotli branch January 8, 2025 20:38

bjohansebas commented Jan 8, 2025

Copy link
Copy Markdown
Member Author

Thanks to everyone who made this possible

This was referenced Jan 8, 2025
Closed
Merged

pratikborsadiya commented Mar 5, 2025

Copy link
Copy Markdown

@nicksrandall @danielgindi @bjohansebas This feature will save a huge chunk of the overall internet data transfers thanks to the widespread use of Express and 20 million weekly downloads of this package. Kudos for the efforts you've put in to enable this 🎉

bjohansebas mentioned this pull request May 11, 2025
Merged
13 tasks
nobodysfool mentioned this pull request Jul 18, 2025
Merged
n-dering mentioned this pull request Jul 19, 2025
Open
coderabbitai Bot mentioned this pull request Apr 14, 2026
Merged
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

blakeembrey blakeembrey approved these changes
wesleytodd wesleytodd approved these changes
UlisesGascon Awaiting requested review from UlisesGascon
+1 more reviewer
nscuilla-godaddy nscuilla-godaddy left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

bjohansebas

Labels

semver-minor tc agenda

Projects

None yet

Milestone

1.8.0

Development

Successfully merging this pull request may close these issues.

Back | FazBrowse Home | New Git URL