fix(integrations): Gate REMOTE_ADDR on data_collection.user_info - #7298
Open
ericapisani wants to merge 1 commit into
Open
fix(integrations): Gate REMOTE_ADDR on data_collection.user_info#7298ericapisani wants to merge 1 commit into
ericapisani wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
REMOTE_ADDR was previously set unconditionally in the request env for aiohttp, sanic, and tornado. Now it respects the data_collection.user_info experiment when data collection is enabled, falling back to the legacy unconditional behaviour otherwise. Fixes PY-2751 Fixes #7297
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Codecov Results 📊✅ 119255 passed | ❌ 1 failed | ⏭️ 6762 skipped | Total: 126018 | Pass Rate: 94.63% | Execution Time: 418m 11s 📊 Comparison with Base Branch
➕ New Tests (1)View new tests
❌ Failed Teststest_continuous_profiler_auto_start_and_stop_sampled[experiment-thread]File: tests.profiler.test_continuous_profiler tests/profiler/test_continuous_profiler.py:812: in test_continuous_profiler_auto_start_and_stop_sampled
assert get_profiler_id() is None, "profiler should not be running"
E AssertionError: profiler should not be running
E assert '160b380ae6cf4e4784280cffc84219d8' is None
E + where '160b380ae6cf4e4784280cffc84219d8' = get_profiler_id()
✅ Patch coverage is 100.00%. Project has 2492 uncovered lines. @@ Coverage Diff @@
## main #PR +/-##
==========================================
- Coverage 90.30% 90.27% -0.03%
==========================================
Files 193 193 —
Lines 25601 25604 +3
Branches 9436 9442 +6
==========================================
+ Hits 23116 23112 -4
- Misses 2485 2492 +7
- Partials 1435 1435 —Generated by Codecov Action |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
REMOTE_ADDR was previously set unconditionally in the request env for aiohttp, sanic, and tornado. Now it respects the data_collection.user_info experiment when data collection is enabled, falling back to the legacy unconditional behaviour otherwise.
Fixes PY-2751
Fixes #7297