Extract semantic CLI version from URL when requesting specific tools - #1682
Merged
henrymercer merged 4 commits intoMay 18, 2023
Merged
Extract semantic CLI version from URL when requesting specific tools#1682henrymercer merged 4 commits into
henrymercer merged 4 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
angelapwen
previously approved these changes
May 16, 2023
angelapwen
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Nice, thanks for doing some of the testing refactoring too 😸
Sorry, something went wrong.
angelapwen
previously approved these changes
May 17, 2023
Comment thread
CHANGELOG.md
Outdated
adityasharad
approved these changes
May 17, 2023
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR prepares the Action for migrating the CodeQL Bundle to be versioned using a semantic version (e.g. codeql-bundle-v1.2.3). Most of the work is already done, but this PR makes a small improvement to ensure we can look up CLIs requested via tools in the tool cache before downloading them. Specifically, we populate cliVersion when we can recognize that the requested CodeQL Bundle tag uses a semantic version. The rest of the changes here are pulling out shared test utilities so we can write more specific CodeQL setup tests in setup-codeql.test.ts.
There's scope for some cleanup and refactoring here now we're migrating the bundle version to semver, but this will be easier to do once this change is fully rolled out.
We also add a changelog note to notify customers about the change to the way that bundles will be tagged for future CodeQL versions.
Merge / deployment checklist