Add a feature flag to use a bundle compressed using Zstandard when setting up the default tools - #2502
Merged
henrymercer merged 16 commits intoSep 27, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
aeisenberg
reviewed
Sep 23, 2024
Comment thread
pr-checks/checks/zstd-bundle-fallback.yml
Outdated
Comment thread
pr-checks/checks/zstd-bundle.yml
Comment thread
src/setup-codeql.ts
Outdated
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com>
aeisenberg
approved these changes
Sep 26, 2024
aeisenberg
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM!
Sorry, something went wrong.
NlightNFotis
approved these changes
Sep 27, 2024
NlightNFotis
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
This was referenced Sep 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a feature flag to download a CodeQL Bundle compressed using Zstandard when setting up the default tools.
If we determine that tar is new enough, we will download the zstd-compressed bundle.
We add a fallback mechanism: if setting up the zstd-compressed bundle fails, we will fall back to the gzip-compressed bundle.
We add PR checks to validate both setting up a zstd-compressed bundle when the feature flag is enabled, and the fallback mechanism.
Merge / deployment checklist