Pass --ignore-zeros to tar when decompressing zstd-compressed tarballs - #2768
Pass --ignore-zeros to tar when decompressing zstd-compressed tarballs#2768henrymercer merged 2 commits into
Conversation
Sorry, something went wrong.
…arballs See comment in the diff for full explanation.
There was a problem hiding this comment.
PR Overview
This PR updates the tar extraction command for zstd-compressed tarballs by adding the "--ignore-zeros" flag to address potential issues when the archive contains trailing zero bytes.
- Updated the argument array in the extractTarZst function to include "--ignore-zeros".
- Added detailed comments explaining the need for the additional flag and linking to a relevant issue for context.
Changes
| File | Description |
|---|---|
| src/tar.ts | Updated the tar extraction command to safely handle trailing zeroes by passing --ignore-zeros. |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
Sorry, something went wrong.
|
Pushed a commit to rebuild the Action. Please mark the PR as ready for review to trigger PR checks. |
Sorry, something went wrong.
henrymercer
left a comment
There was a problem hiding this comment.
Thanks for the thorough investigation and explanation! This looks good to me assuming checks pass.
Do you have an opinion about whether this means we should revert #2767 and return to preferring bsdtar on macOS systems? If we revert that PR, we should add a changenote to this one.
Sorry, something went wrong.
|
No strong opinion -- using gtar is also fine. This should probably be done anyhow since it means we'll work better with BSD tar whenever it's the only one around. |
Sorry, something went wrong.
See comment in the diff for full explanation.
Merge / deployment checklist