Remove disable_combine_sarif_files feature flag - #2991
koesie10 merged 2 commits into
Conversation
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR removes the disable_combine_sarif_files feature flag which is currently fully enabled and no longer needed. The change simplifies the codebase by removing feature flag checks and directly applying the behavior that was previously controlled by the flag.
- Removes the DisableCombineSarifFiles feature flag enum value and configuration
- Updates function signatures to remove the features parameter from SARIF file combination logic
- Simplifies test cases by removing feature flag-related test setup and scenarios
Reviewed Changes
Copilot reviewed 6 out of 9 changed files in this pull request and generated no comments.
Show a summary per file| File | Description |
|---|---|
| src/upload-lib.ts | Removes feature flag parameter from functions and simplifies SARIF file combination logic |
| src/upload-lib.test.ts | Updates test cases to remove feature flag dependencies and removes redundant test |
| src/feature-flags.ts | Removes the DisableCombineSarifFiles enum value and configuration |
| lib/upload-lib.test.js | Generated JavaScript equivalent of test file changes |
| lib/upload-lib.js | Generated JavaScript equivalent of main implementation changes |
| lib/feature-flags.js | Generated JavaScript equivalent of feature flag removal |
Sorry, something went wrong.
|
For the failing tests, it's probably easiest to wait for CLI 2.16.6 support to be dropped (which I suggested here). |
Sorry, something went wrong.
mbg
left a comment
There was a problem hiding this comment.
The changes make sense to me, thank you!
Sorry, something went wrong.
This removes the disable_combine_sarif_files feature flag which is currently fully enabled.
Merge / deployment checklist