Fix missing/wrong properties in createTestConfig - #3071
Merged
mbg merged 2 commits intoSep 2, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes inconsistencies in the createTestConfig function by adding missing properties and correcting property types to match the actual Config interface. The changes ensure the test configuration object properly reflects the structure of production configurations.
- Adds missing overlay database properties (overlayDatabaseMode and useOverlayDatabaseCaching)
- Corrects the type of dependencyCachingEnabled from boolean to CachingKind.None
- Adds explicit type casting to ensure type safety
Sorry, something went wrong.
esbena
reviewed
Sep 2, 2025
Comment thread
src/testing-utils.ts
Outdated
Co-authored-by: Esben Sparre Andreasen <esbena@github.com>
esbena
approved these changes
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #3064. Fixes some incorrect properties in createTestConfig.
Risk assessment
For internal use only. Please select the risk level of this change:
Merge / deployment checklist