Hard-code quality queries - #3074
Merged
mbg merged 3 commits intoSep 2, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the deprecated quality-queries input by hard-coding the code quality queries to use ["code-quality"]. This is part of a larger effort to remove AugmentationProperties from Config and transition users to the analysis-kinds input instead.
Key changes:
- Deprecation warning added for the quality-queries input
- Hard-coded quality queries to ["code-quality"] instead of using the input parameter
- Removed qualityQueriesInput from configuration interfaces and processing logic
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.
Show a summary per file| File | Description |
|---|---|
| src/init-action.ts | Adds deprecation warning for quality-queries input and passes it to config initialization |
| src/config-utils.ts | Removes qualityQueriesInput from AugmentationProperties and calculateAugmentation function |
| src/config-utils.test.ts | Updates tests to remove quality-queries parameter from test cases |
| src/analyze.ts | Replaces quality queries input with hard-coded code-quality queries from analyses module |
| src/analyses.ts | Adds hard-coded codeQualityQueries constant |
| init/action.yml | Updates quality-queries input description to indicate deprecation |
Sorry, something went wrong.
Comment thread
src/config-utils.ts
henrymercer
approved these changes
Sep 2, 2025
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #3064 to facilitate unblock removing AugmentationProperties from Config in a follow-up PR.
The quality-queries input will be removed in favour of analysis-kinds. Internally, we have already only used quality-queries with code-quality as argument, so hard-coding this here does not make a difference right now.
Risk assessment
For internal use only. Please select the risk level of this change:
Merge / deployment checklist