Fix hasActionsWorkflows throwing an exception if the workflows folder doesn't exist - #3084
Merged
mbg merged 2 commits intoSep 8, 2025
Merged
Fix hasActionsWorkflows throwing an exception if the workflows folder doesn't exist#3084mbg merged 2 commits into
mbg merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where the hasActionsWorkflows function would throw an exception when the .github/workflows folder doesn't exist. The fix uses the throwIfNoEntry: false option in fs.lstatSync to return undefined instead of throwing when the path doesn't exist.
- Updated fs.lstatSync to use { throwIfNoEntry: false } option to handle non-existent directories gracefully
- Added a test case to verify the function doesn't throw when the workflows folder is missing
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/config-utils.ts | Fixed hasActionsWorkflows to handle missing workflows directory without throwing |
| src/config-utils.test.ts | Added test to verify the function handles missing workflows folder gracefully |
| lib/init-action.js | Generated JavaScript file (not reviewed per guidelines) |
Sorry, something went wrong.
esbena
approved these changes
Sep 8, 2025
8 tasks
krsjenswbp
reviewed
Sep 11, 2025
krsjenswbp
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
merge
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This problem was introduced in #3009 since lstatSync throws an exception by default if the filesystem object doesn't exist.
We likely didn't come across this because it requires both of the following conditions to hold:
Risk assessment
For internal use only. Please select the risk level of this change:
Merge / deployment checklist