Remove quality-queries input - #3458
Draft
mbg wants to merge 2 commits into
Draft
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the deprecated quality-queries input from the CodeQL init action and changes behavior so that any usage results in a configuration error.
Changes:
- Update getAnalysisKinds to throw ConfigurationError if quality-queries is provided.
- Remove quality-queries from init/action.yml inputs.
- Update unit tests and add a changelog entry documenting the removal.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file| File | Description |
|---|---|
| src/analyses.ts | Converts quality-queries handling from a warning/back-compat behavior to a hard error. |
| src/analyses.test.ts | Updates expectations to assert ConfigurationError is thrown when quality-queries is used. |
| lib/init-action.js | Generated JS output reflecting the TS changes. |
| init/action.yml | Removes the quality-queries input definition from the init action metadata. |
| CHANGELOG.md | Notes the removal of the experimental quality-queries input under UNRELEASED. |
src/analyses.ts:69
- getAnalysisKinds populates cachedAnalysisKinds before checking for the removed quality-queries input. If a first call hits the quality-queries error (e.g., the initial call in init-action.ts is caught/ignored), the cache remains set and subsequent calls will return early without re-checking quality-queries, effectively bypassing the intended hard error. Consider checking quality-queries before returning/setting the cache (and avoid mutating the cache when throwing), or always re-check quality-queries even when cached.
if (!skipCache && cachedAnalysisKinds !== undefined) {
return cachedAnalysisKinds;
}
cachedAnalysisKinds = await parseAnalysisKinds(
Sorry, something went wrong.
Comment thread
src/analyses.test.ts
mbg
marked this pull request as draft
February 10, 2026 09:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We deprecated this short-lived, experimental input in CodeQL Action 3.30.2. This PR removes its remaining functionality and turns any use of it into an error.
Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Workflow types:
Products:
Environments:
How did/will you validate this change?
If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Are there any special considerations for merging or releasing this change?
Merge / deployment checklist