FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Load custom repository properties on GHES and remove feature flag by henrymercer · Pull Request #3559 · github/codeql-action · GitHub

/ codeql-action Public

Load custom repository properties on GHES and remove feature flag - #3559

Merged
henrymercer merged 5 commits into
mainfrom
henrymercer/ghes-repository-properties
Mar 9, 2026
ConversationCommits (5)ChecksFiles changed
Merged

Load custom repository properties on GHES and remove feature flag#3559
henrymercer merged 5 commits into
mainfrom
henrymercer/ghes-repository-properties

Conversation

henrymercer commented Mar 9, 2026

Copy link
Copy Markdown
Contributor
  • Clean up the repository properties feature flag now that this has been fully enabled for a while.
  • Start loading repository properties on GHES, since this API is available on all supported GHES versions (since 3.13)

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Which use cases does this change impact?

Workflow types:

  • Advanced setup - Impacts users who have custom CodeQL workflows.
  • Managed - Impacts users with dynamic workflows (Default Setup, Code Quality, ...).

Products:

  • Code Scanning - The changes impact analyses when analysis-kinds: code-scanning.
  • Code Quality - The changes impact analyses when analysis-kinds: code-quality.
  • Other first-party - The changes impact other first-party analyses.
  • Third-party analyses - The changes affect the upload-sarif action.

Environments:

  • Dotcom - Impacts CodeQL workflows on github.com and/or GitHub Enterprise Cloud with Data Residency.
  • GHES - Impacts CodeQL workflows on GitHub Enterprise Server.

How did/will you validate this change?

  • None - I am not validating these changes.

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

  • Rollback - Change can only be disabled by rolling back the release or releasing a new version with a fix.

How will you know if something goes wrong after this change is released?

  • Telemetry - I rely on existing telemetry or have made changes to the telemetry.
    • Alerts - New or existing monitors will trip if something goes wrong with this change.

Are there any special considerations for merging or releasing this change?

  • No special considerations - This change can be merged at any time.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

henrymercer requested a review from a team as a code owner March 9, 2026 16:23
Copilot AI review requested due to automatic review settings March 9, 2026 16:23
github-actions Bot added the size/M Should be of average difficulty to review label Mar 9, 2026
mbg previously approved these changes Mar 9, 2026
View reviewed changes
github-actions Bot added size/S Should be easy to review and removed size/M Should be of average difficulty to review labels Mar 9, 2026
henrymercer enabled auto-merge March 9, 2026 16:26
Copilot AI reviewed Mar 9, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Pull request overview

This PR removes the now-unneeded repository properties feature flag and enables loading custom repository properties on GHES, so server-side configuration (e.g. github-codeql-disable-overlay) works consistently across GitHub.com and GHES.

Changes:

  • Remove the UseRepositoryProperties feature flag and its gating logic.
  • Enable repository properties loading on GHES by removing the GHES short-circuit.
  • Update unit tests and changelog entry accordingly (and regenerate lib/ outputs).

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/init-action.ts Removes feature-flag gating for repository properties loading.
src/feature-flags/properties.ts Removes the GHES “always return {}” behavior so the API is called on GHES too.
src/feature-flags/properties.test.ts Updates tests to match the new loadPropertiesFromApi signature and behavior.
src/feature-flags.ts Removes the UseRepositoryProperties feature flag from the enum and config.
CHANGELOG.md Adds an UNRELEASED entry describing repository properties now loading on GHES.
lib/upload-sarif-action.js Generated output updated for removed feature flag.
lib/upload-sarif-action-post.js Generated output updated for removed feature flag.
lib/upload-lib.js Generated output updated for removed feature flag.
lib/start-proxy-action.js Generated output updated for removed feature flag.
lib/start-proxy-action-post.js Generated output updated for removed feature flag.
lib/setup-codeql-action.js Generated output updated for removed feature flag.
lib/resolve-environment-action.js Generated output updated for removed feature flag.
lib/init-action.js Generated output updated for removed feature flag and repo properties changes.
lib/init-action-post.js Generated output updated for removed feature flag.
lib/autobuild-action.js Generated output updated for removed feature flag.
lib/analyze-action.js Generated output updated for removed feature flag.
lib/analyze-action-post.js Generated output updated for removed feature flag.

Comment thread src/init-action.ts Outdated
Comment thread src/feature-flags/properties.ts
github-actions Bot added size/M Should be of average difficulty to review and removed size/S Should be easy to review labels Mar 9, 2026
henrymercer requested a review from mbg March 9, 2026 16:47
henrymercer added this pull request to the merge queue Mar 9, 2026
Merged via the queue into main with commit 3c97288 Mar 9, 2026
244 checks passed
henrymercer deleted the henrymercer/ghes-repository-properties branch March 9, 2026 17:47
This was referenced Mar 16, 2026
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
mbg mbg approved these changes

Assignees

No one assigned

Labels

size/M Should be of average difficulty to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL