Deprecate TRAP cache cleanup - #3795
Merged
henrymercer merged 1 commit intoApr 7, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull request overview
Deprecates the TRAP cache cleanup feature by surfacing a runtime warning and documenting the deprecation timeline in the changelog, aligning with the goal of reducing required permissions for analyze and discouraging use of this undocumented behavior.
Changes:
- Emit a deprecation warning when TRAP cache cleanup is enabled.
- Document the deprecation and removal timeline in CHANGELOG.md.
- Update generated lib/ output to reflect the TypeScript source change.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/trap-caching.ts | Adds a warning indicating TRAP cache cleanup is deprecated and provides guidance to disable TRAP caching. |
| lib/analyze-action.js | Generated build artifact reflecting the src/ change. |
| CHANGELOG.md | Adds an UNRELEASED entry documenting the deprecation, removal date, and mitigation. |
Sorry, something went wrong.
sam-robson
approved these changes
Apr 6, 2026
This was referenced Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This undocumented feature required giving actions: write permission to the analyze job on the default branch. If we were going to move ahead, we would prefer to reimplement this within a separate Action that does the cleanup to limit permissions. However it is most likely that TRAP caching will become less relevant over time given improved incremental analysis supersedes it, so this PR deprecates this little-used and undocumented feature.