Add per-call OAuth scope checks - #3128
Open
SamMorrowDrums wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull request overview
Introduces explicit OAuth authorization policies with alternative paths, conjunctive requirements, and argument-aware scope resolution.
Changes:
- Adds policy modeling, evaluation, hierarchy traversal, and compatibility projection.
- Resolves scopes dynamically for repository/org operations and workflow-file writes.
- Adds path validation, middleware integration, documentation, and tests.
| File | Description |
|---|---|
| pkg/scopes/scopes.go | Implements policy construction and evaluation. |
| pkg/scopes/scopes_test.go | Tests policy semantics and hierarchy expansion. |
| pkg/scopes/map.go | Maps and resolves tool scope policies. |
| pkg/scopes/map_test.go | Tests call-specific policy resolution. |
| pkg/inventory/server_tool.go | Adds policy metadata to tools. |
| pkg/inventory/server_tool_test.go | Verifies path headers are excluded. |
| pkg/http/middleware/scope_challenge.go | Applies resolved policies to OAuth challenges. |
| pkg/http/middleware/scope_challenge_test.go | Tests argument-aware challenges. |
| pkg/github/ui_tools.go | Adds a scope resolver to ui_get. |
| pkg/github/tool_scopes.go | Defines repository/org and UI policies. |
| pkg/github/tool_scopes_test.go | Tests conditional tool policies. |
| pkg/github/scope_filter.go | Filters tools using authorization paths. |
| pkg/github/scope_filter_test.go | Tests compatibility and fail-open behavior. |
| pkg/github/repository_path.go | Validates paths and detects workflow writes. |
| pkg/github/repository_path_test.go | Tests path safety and workflow policies. |
| pkg/github/repositories.go | Applies validation and dynamic write policies. |
| pkg/github/issues.go | Adds issue-type scope resolution. |
| pkg/github/issue_fields.go | Adds issue-field scope resolution. |
| pkg/github/header_params_test.go | Ensures paths remain in MCP arguments. |
| pkg/github/dependencies.go | Initializes legacy-compatible policies. |
| docs/scope-filtering.md | Documents the policy model. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 21/21 changed files
- Comments generated: 2
- Review effort level: Balanced
Sorry, something went wrong.
Comment thread
pkg/github/tool_scopes.go
Outdated
Comment thread
pkg/github/repository_path.go
Outdated
SamMorrowDrums
force-pushed
the
sammorrowdrums-scope-policy-model
branch
from
442d43f to
96f14fd
Compare
August 21, 2026 00:16
SamMorrowDrums
force-pushed
the
sammorrowdrums-scope-policy-model
branch
2 times, most recently
from
05d9ff1 to
1cadd8a
Compare
August 24, 2026 09:57
Let each tool define fixed-token visibility and return the exact scopes for an OAuth challenge based on the current call. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 26e41558-43f9-42b2-8569-8489957c2b0a
SamMorrowDrums
force-pushed
the
sammorrowdrums-scope-policy-model
branch
from
1cadd8a to
1850911
Compare
August 24, 2026 12:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Give each tool two straightforward scope checks:
Static tools use small helpers such as RequireAll. Conditional tools use ordinary Go functions over the tool arguments and active token scopes.
Why
Scope requirements can depend on the call. Listing issue fields uses repo for a repository request and read:org for an organization request. File writes need workflow in addition to repo only when changing a workflow file.
Keeping visibility and per-call challenges separate avoids flattening these cases into one scope list or introducing a policy language.
What changed
Related work
Supersedes #2778 and #3092.