Suggested fixes by iCR, OpenRefactory, Inc. - #1486
Closed
openrefactory wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
It's by design, the temporary file has to be opened and written by git in a separate process, and is later renamed. If a human is going to make this PR work though which I doubt, please feel free to open a new one with a personal note. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
In case anyone finds this when searching for other PRs, the issues mentioned here were effectively fixed (among other changes): |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue was detected in branch main of GitPython project on the version with commit hash 73bde1. This is an instance of an improper method call
Fixes for improper method call:
In file: base.py, there is a method from_tree that creates a temporary file using an unsafe API mktemp. The use of this method is discouraged in the Python documentation. iCR suggested that a temporary file should be created using NamedTemporaryFile which is a a safe API. iCR replaced the usage of mktemp with NamedTemporaryFile.
In file: util.py, there is a method __init__ that creates a temporary file using an unsafe API mktemp. The use of this method is discouraged in the Python documentation. iCR suggested that a temporary file should be created using NamedTemporaryFile which is a a safe API. iCR replaced the usage of mktemp with NamedTemporaryFile.
This issue was detected by OpenRefactory's Intelligent Code Repair (iCR). We are running iCR on libraries in the PyPI repository to identify issues and fix them. More info at: pypi.openrefactory.com