FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix ignored by Lightborne · Pull Request #1545 · gitpython-developers/GitPython · GitHub

/ GitPython Public

Fix ignored - #1545

Merged
Byron merged 3 commits into
gitpython-developers:mainfrom
Lightborne:fix_ignored
Jan 22, 2023
ConversationCommits (3)ChecksFiles changed
Merged

Fix ignored#1545
Byron merged 3 commits into
gitpython-developers:mainfrom
Lightborne:fix_ignored

Conversation

Lightborne commented Jan 21, 2023

Copy link
Copy Markdown
Contributor
  • Add test to sanity-check basic behavior of ignored() method
  • Add test to verify GitCommandError is raised if git check-ignore returns any error code other than 1
  • Modify ignred() method to raise GitCommandError if git check-ignore returns any error code other than 1

Lightborne mentioned this pull request Jan 21, 2023
Closed
Byron added this to the v3.1.31 - Bugfixes milestone Jan 22, 2023

Byron commented Jan 22, 2023

Copy link
Copy Markdown
Member

Great work, thanks so much! I love to finally have a test for that.

For a moment I thought this might be a breaking change, just to realize that the previous implementation was just a little too 'unconditional' and this PR implements the proper fix by raising an error when the error code does not indicate a lack of matches.

Byron merged commit cc92d51 into gitpython-developers:main Jan 22, 2023

Lightborne commented Jan 23, 2023

Copy link
Copy Markdown
Contributor Author

Thanks so much!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

v3.1.31 - Bugfixes

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL