Skip cross-drive relative config test on Windows by Byron · Pull Request #2171 · gitpython-developers/GitPython · GitHub

Tasks

This section is for Byron only. Models continuing this PR must not add, remove, check, uncheck, rename, or reorder checkboxes here.

refackiew

Everything below this line was generated by Codex GPT-5.

Created by Codex on behalf of Byron. Byron will review before this is ready to merge.

Reported issue

On Windows, this test is failing. Maybe fix by not running it there:

FAILED test/test_config.py::TestBase::test_config_relative_path_include - ValueError: path is on mount 'C:', start on mount 'D:'\n= 1 failed, 700 passed, 45 skipped, 13 xfailed, 1 xpassed, 3 warnings in 305.88s (0:05:05) =\n```\n\n## Change\n\nSkip `test_config_relative_path_include` only when the temporary config and current working directory are on different drives. Same-drive Windows environments retain coverage.\n\n## Validation\n\n- `pytest -q test/test_config.py` (31 passed, 1 existing skip)\n- `ruff check test/test_config.py`\n- `ruff format --check test/test_config.py`\n- Codex review of `67082d64` (no findings)

On Windows, the writable temporary directory and the checkout can be on different drives. os.path.relpath() raises ValueError for such paths before GitConfigParser is exercised. Skip this relative-path-specific test on Windows, where the test setup cannot reliably construct the required relative path. Validation: - pytest -q test/test_config.py - ruff check test/test_config.py - ruff format --check test/test_config.py

Merging early as it should fix the windows test, and there don't seem to be many runners these days.

Pull request overview

This PR addresses a Windows-specific failure in test_config_relative_path_include caused by os.path.relpath() raising ValueError when the temporary directory and the current working directory are on different drives. It adds a conditional skip so the test is only skipped in the cross-drive scenario, preserving coverage when both are on the same drive.

Changes:

Add a runtime check comparing the drive of config_path vs the current working directory.
Skip the test when those drives differ to avoid relpath() cross-drive failures on Windows.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

This MR contains the following updates: | Package | Type | Update | Change | OpenSSF | |---|---|---|---|---| | [gitpython](https://github.com/gitpython-developers/GitPython) | dev | patch | `3.1.50` → `3.1.52` | [![OpenSSF Scorecard](https://api.securityscorecards.dev/projects/github.com/gitpython-developers/GitPython/badge)](https://securityscorecards.dev/viewer/?uri=github.com/gitpython-developers/GitPython) | --- ### Release Notes <details> <summary>gitpython-developers/GitPython (gitpython)</summary> ### [`v3.1.52`](https://github.com/gitpython-developers/GitPython/releases/tag/3.1.52): Security [Compare Source](gitpython-developers/GitPython@3.1.51...3.1.52) <GHSA-rwj8-pgh3-r573>: Environment-variable exfiltration via os.path.expandvars() on Repo.clone\_from() URL #### What's Changed - Skip cross-drive relative config test on Windows by [@Byron](https://github.com/Byron) in [#2171](gitpython-developers/GitPython#2171) - fix: preserve literal clone URLs by [@Byron](https://github.com/Byron) in [#2172](gitpython-developers/GitPython#2172) **Full Changelog**: <gitpython-developers/GitPython@3.1.51...3.1.52> ### [`v3.1.51`](https://github.com/gitpython-developers/GitPython/releases/tag/3.1.51): - Security [Compare Source](gitpython-developers/GitPython@3.1.50...3.1.51) #### What's Changed - Add AI-disclosure and quality requirements to the contribution guidelines by [@Byron](https://github.com/Byron) in [#2143](gitpython-developers/GitPython#2143) - docs(cmd): clarify Git.execute() string vs list command argument by [@mvanhorn](https://github.com/mvanhorn) in [#2144](gitpython-developers/GitPython#2144) - Rewrite Git.execute() command parameter docstring per [#2146](gitpython-developers/GitPython#2146) by [@EliahKagan](https://github.com/EliahKagan) in [#2147](gitpython-developers/GitPython#2147) - Document init script behavior with multiple master remotes by [@EliahKagan](https://github.com/EliahKagan) in [#2148](gitpython-developers/GitPython#2148) - Bump git/ext/gitdb from `335c0f6` to `0a019a2` by [@dependabot](https://github.com/dependabot)\[bot] in [#2149](gitpython-developers/GitPython#2149) - Support relative worktree paths (git 2.48+ worktree.useRelativePaths) by [@elovelan](https://github.com/elovelan) in [#2151](gitpython-developers/GitPython#2151) - Defer xfail condition evaluation with xfail\_if\_raises context manager by [@elovelan](https://github.com/elovelan) in [#2153](gitpython-developers/GitPython#2153) - Run more submodule tests on Cygwin (fix flaky xfails) by [@EliahKagan](https://github.com/EliahKagan) in [#2154](gitpython-developers/GitPython#2154) - Cut xtrace noise from POSIX-ownership diagnostic steps by [@EliahKagan](https://github.com/EliahKagan) in [#2156](gitpython-developers/GitPython#2156) - Support index diffs against the empty tree by [@puneetdixit200](https://github.com/puneetdixit200) in [#2155](gitpython-developers/GitPython#2155) - refactor: seperate out Progress type by [@LoeschMaximilian](https://github.com/LoeschMaximilian) in [#2157](gitpython-developers/GitPython#2157) - Bump <https://github.com/astral-sh/ruff-pre-commit> from v0.15.12 to 0.15.15 in the pre-commit group by [@dependabot](https://github.com/dependabot)\[bot] in [#2160](gitpython-developers/GitPython#2160) - Bump actions/checkout from 6 to 7 by [@dependabot](https://github.com/dependabot)\[bot] in [#2164](gitpython-developers/GitPython#2164) - Bump git/ext/gitdb from `0a019a2` to `4950ea9` by [@dependabot](https://github.com/dependabot)\[bot] in [#2165](gitpython-developers/GitPython#2165) - Bump <https://github.com/astral-sh/ruff-pre-commit> from v0.15.15 to 0.15.20 in the pre-commit group by [@dependabot](https://github.com/dependabot)\[bot] in [#2166](gitpython-developers/GitPython#2166) - Add Commit.is\_shallow property; document stats() limitation at shallow boundary by [@harshitayadavv](https://github.com/harshitayadavv) in [#2167](gitpython-developers/GitPython#2167) - Allow relative config paths with includes by [@Byron](https://github.com/Byron) in [#2169](gitpython-developers/GitPython#2169) - Reject abbreviated forms of unsafe git options by [@Byron](https://github.com/Byron) in [#2168](gitpython-developers/GitPython#2168) - guard unsafe git command options by [@Byron](https://github.com/Byron) in [#2163](gitpython-developers/GitPython#2163) #### New Contributors - [@elovelan](https://github.com/elovelan) made their first contribution in [#2151](gitpython-developers/GitPython#2151) - [@puneetdixit200](https://github.com/puneetdixit200) made their first contribution in [#2155](gitpython-developers/GitPython#2155) - [@LoeschMaximilian](https://github.com/LoeschMaximilian) made their first contribution in [#2157](gitpython-developers/GitPython#2157) - [@harshitayadavv](https://github.com/harshitayadavv) made their first contribution in [#2167](gitpython-developers/GitPython#2167) **Full Changelog**: <gitpython-developers/GitPython@3.1.50...3.1.51> </details> --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate).  See merge request swiss-armed-forces/cyber-command/cea/loom!679 Co-authored-by: Loom MR Pipeline Trigger <group_103951964_bot_9504bb8dead6d4e406ad817a607f24be@noreply.gitlab.com>

Copilot AI review requested due to automatic review settings July 12, 2026 14:00

Copilot started reviewing on behalf of Byron July 12, 2026 14:02 View session

Byron merged commit 7a46dfc into main Jul 12, 2026
30 of 31 checks passed

Byron deleted the fix-windows-tests branch July 12, 2026 14:02

Copilot AI reviewed Jul 12, 2026

View reviewed changes

Comment thread test/test_config.py

Comment on lines +323 to +324

if osp.splitdrive(config_path)[0] != osp.splitdrive(os.getcwd())[0]:

pytest.skip("The temporary directory and checkout are on different drives")

Skip cross-drive relative config test on Windows by Byron · Pull Request #2171 · gitpython-developers/GitPython · GitHub

Uh oh!

Uh oh!

Skip cross-drive relative config test on Windows - #2171

Skip cross-drive relative config test on Windows#2171
Byron merged 1 commit into
mainfrom
fix-windows-tests

Byron commented Jul 12, 2026 •
edited
Loading

Uh oh!

Uh oh!

Byron commented Jul 12, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

		if osp.splitdrive(config_path)[0] != osp.splitdrive(os.getcwd())[0]:
		pytest.skip("The temporary directory and checkout are on different drives")

Skip cross-drive relative config test on Windows by Byron · Pull Request #2171 · gitpython-developers/GitPython · GitHub

Uh oh!

Uh oh!

Skip cross-drive relative config test on Windows - #2171

Skip cross-drive relative config test on Windows#2171Byron merged 1 commit intomaingitpython-developers/GitPython:mainfrom fix-windows-testsgitpython-developers/GitPython:fix-windows-testsCopy head branch name to clipboard

Conversation

Byron commented Jul 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Tasks

Reported issue

Uh oh!

Byron commented Jul 12, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

Skip cross-drive relative config test on Windows#2171
Byron merged 1 commit into
mainfrom
fix-windows-tests

Byron commented Jul 12, 2026 •
edited
Loading