FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore: improve tests without assertions by jorgsowa · Pull Request #1201 · glayzzle/php-parser · GitHub

/ php-parser Public

chore: improve tests without assertions - #1201

Merged
czosel merged 3 commits into
mainfrom
chore/assertion-test
Mar 16, 2026
ConversationCommits (3)ChecksFiles changed
Merged

chore: improve tests without assertions#1201
czosel merged 3 commits into
mainfrom
chore/assertion-test

Conversation

jorgsowa commented Mar 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Test suite warns that the test doesn't have any assertions, so let's add it.

  • test/snapshot/namespace.test.js - filled 3 empty todo tests. Two of them were redundant. There were not enough tests for the use statement.
  • test/snapshot/string.test.js - applied assertions to the test. The test only tested parsing, without checking the proper structure.
  • test/ast.test.js - added assertion

jorgsowa marked this pull request as draft March 16, 2026 20:59
jorgsowa force-pushed the chore/assertion-test branch from 731e2d8 to 66b8f61 Compare March 16, 2026 21:30
jorgsowa changed the title chore: add assertion to the test debug mode chore: improve test without assertions Mar 16, 2026
jorgsowa marked this pull request as ready for review March 16, 2026 22:00
jorgsowa changed the title chore: improve test without assertions chore: improve tests without assertions Mar 16, 2026
czosel approved these changes Mar 16, 2026
View reviewed changes

czosel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

👍

czosel merged commit ba6d1c4 into main Mar 16, 2026
6 checks passed
alexander-akait deleted the chore/assertion-test branch March 17, 2026 10:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

czosel czosel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL