FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: get channel target for a gRPC request by ohmayr · Pull Request #1339 · googleapis/python-pubsub · GitHub

This repository was archived by the owner on Mar 9, 2026. It is now read-only.
/ python-pubsub Public archive

fix: get channel target for a gRPC request - #1339

Merged
mukund-ananthu merged 5 commits into
mainfrom
fix-pubsub-target-issue
Jan 29, 2025
Merged

fix: get channel target for a gRPC request#1339
mukund-ananthu merged 5 commits into
mainfrom
fix-pubsub-target-issue

Conversation

ohmayr commented Jan 22, 2025
edited
Loading

Copy link
Copy Markdown
Contributor

Depends on #1348.

This is a workaround to resolve the issue for accessing the gRPC channel target: b/388826364

Refer to grpc/grpc#38519 for a more stable solution.

ohmayr requested review from a team January 22, 2025 23:05
product-auto-label Bot added size: s Pull request size is small. api: pubsub Issues related to the googleapis/python-pubsub API. size: m Pull request size is medium. and removed size: s Pull request size is small. labels Jan 22, 2025
ohmayr force-pushed the fix-pubsub-target-issue branch from df9cb1e to 135038e Compare January 28, 2025 20:54
product-auto-label Bot added size: s Pull request size is small. and removed size: m Pull request size is medium. labels Jan 28, 2025

Copy link
Copy Markdown
Contributor

@ohmayr Could you please fix the unit tests.

ohmayr commented Jan 28, 2025

Copy link
Copy Markdown
Contributor Author

@ohmayr Could you please fix the unit tests.

As discussed offline, this PR is dependent on #1348 and the unit tests should resolve once we merge it and rebase this PR on top of main.

ohmayr force-pushed the fix-pubsub-target-issue branch from 591a7a9 to 576a948 Compare January 29, 2025 20:56
mukund-ananthu merged commit 16ea766 into main Jan 29, 2025
mukund-ananthu deleted the fix-pubsub-target-issue branch January 29, 2025 21:53
ohmayr added a commit that referenced this pull request Mar 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: pubsub Issues related to the googleapis/python-pubsub API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL